Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request example #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Pull request example #1

wants to merge 1 commit into from

Conversation

hellofanny
Copy link
Owner

@hellofanny hellofanny commented Jan 14, 2021

💬 PR's title should be self-explanatory.

This PR attempts to add a description of the changes proposed in the pull request.
It's possible to reference a related issue in the repository or link.

@mentions of the person or team responsible for reviewing proposed changes or add them as reviewers.

** If still in progress, convert it to draft.

You can add a list of mini-tasks to help you check progress and review.

  • Open a pull request
  • Add description
  • Add screenshots, if possible (it's nice for reviewers, they can point issues before running or checking the code)
  • Apply labels to this pull request, if necessary

Preview - screenshots or videos

It helps reviewers to get a quick picture of what the pull request is about. Can add images of before and after.

Mobile - loading Desktop - loading
mobile-preview desktop-preview

@hellofanny hellofanny changed the title Create pull_request_example.md Pull request example Jan 14, 2021
@hellofanny hellofanny added the documentation Improvements or additions to documentation label Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant