Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dell OS10 improvements #278

Merged
merged 11 commits into from
Nov 12, 2024
Merged

Dell OS10 improvements #278

merged 11 commits into from
Nov 12, 2024

Conversation

jbemmel
Copy link

@jbemmel jbemmel commented Oct 31, 2024

  • Wait while system gives "loading" prompt
  • Add note on qcow2 compression, reduced image to ~30% in my case for 10.5.6.6:
    -rw-r--r-- 1 jvanbemmel jvanbemmel 2336227328 Oct 31 08:54 dellftos.10.5.6.6.qcow2

More general changes:

  • Refactor management IP network settings, make them configurable
  • Change Dell OS10 management link to private 169.254.127.0/24 range, to minimize chance at overlap with other configs ( original 10.0.0.0/24 is way too common ... )
  • Forward only the TCP ports used by the platform, not the full set of those used by all other platforms
  • Address warnings caused by format strings to logger

@hellt
Copy link
Owner

hellt commented Nov 9, 2024

Since #279 has been started, it would make sense to ensure that ftos works with the scrapli driver. The plan is to remove telnet scraping in a short while as it served its time

@jbemmel
Copy link
Author

jbemmel commented Nov 9, 2024

I’m fine with that, but can we accept this PR in the meantime until the ideal architecture is available?

OS10 is currently broken

@hellt
Copy link
Owner

hellt commented Nov 9, 2024

@log1cb0mb, @ssasso, @nlgotz hi all, you have contributed to ftosv support in the past, since this PR is intrusive, would you care to try it out before it gets merged?

@jbemmel
Copy link
Author

jbemmel commented Nov 9, 2024

@log1cb0mb, @ssasso, @nlgotz hi all, you have contributed to ftosv support in the past, since this PR is intrusive, would you care to try it out before it gets merged?

I didn't intend to submit those more radical refactorings as part of this PR, guess I forgot to switch branches - sorry.
Happy to refactor and include just the "waiting for OS10" changes

* Remove commented code block
@ssasso
Copy link

ssasso commented Nov 12, 2024

It is working on my machine! :) tnx @jbemmel for solving the annoying "loading" stuff.

@hellt
Copy link
Owner

hellt commented Nov 12, 2024

thnx @ssasso and @jbemmel

@hellt hellt merged commit 89694a6 into hellt:master Nov 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants