[Stacked] Non-consuming bullet_stream alternative #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/bs_diff
branch
from
96fd476 to
a31801e
Compare
schneems
force-pushed
the
schneems/bs_diff_no_consume
branch
from
ca219d0 to
3fbc652
Compare
schneems
force-pushed
the
schneems/bs_diff_no_consume
branch
from
3fbc652 to
a45f4a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR plays on top of #327 and demonstrates the difference between the two APIs.
It feels much less cumbersome to use, but the delta in terms of actual code reduction is smaller than I would have guessed, just -37 lines.: