This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Fix version detection #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this in to fix the version regression. Added #14 to track some other uncovered surface area. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix Issue #12
It looks like a big change, but its actually almost the same as the grep/sed used before (82da8fe), but still extracted into common.sh and just allowing a trailing A-Za-z (no dashes and no leading alphas). It is also play-specific instead of trying to be generic for any property -- there were some regex issues with that and isn't really needed for play, so keeping it simple. Also tests were renamed and changed to match new function name along with a bunch of new tests for the situation the customer ran into.