Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(net-rc,cwd): adds more robust netrc parsing and cwd detection #133

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

justinwilaby
Copy link
Contributor

@justinwilaby justinwilaby commented Mar 5, 2025

fixes #134
fixes #135

This PR addresses 2 edge cases:

  1. a non-encrypted .netrc file which contains strange whitespace - this was reported by 1 user
  2. A better detection for the cwd passed to the child process for CLI execution

Testing

These are edge cases and cannot be easily tested. Testing the above is limited to verifying no regressions are introduced.

  1. Make sure sign in/sign out still works
  2. Make sure you can link at least 1 app to the workspace.

W-17969497
W-17969515

@justinwilaby justinwilaby requested a review from a team as a code owner March 5, 2025 15:18
Copy link

@sbosio sbosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tested and both log-in and heroku git commands worked perfectly when linking a workspace with an app.

@justinwilaby justinwilaby merged commit 6e58a2d into main Mar 6, 2025
1 check passed
@justinwilaby justinwilaby deleted the jw/netrc-parsing branch March 6, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants