Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate external packages to internal to avoid version incompatibility #4655

Open
wants to merge 63 commits into
base: canary
Choose a base branch
from

Conversation

wingkwong
Copy link
Member

@wingkwong wingkwong commented Jan 26, 2025

Closes #4567

📝 Description

Currently users may need to install some external packages. However, since we are using fixed versions for them in HeroUI to avoid unexpected issues, users still may install the latest version (even the doc explicitly defines the exact version). The version incompatibility causes issues from time to time.

This PR is to create a mirror version of the following package so that users will use the exact same version.

  • @internationalized/date -> @heroui/internationalized-date
  • @react-aria/i18n -> @heroui/react-aria-i18n
  • framer-motion -> @heroui/motion (also migrated to motion v12)

There three packages will not be included in @heroui/react. The reasons are

  • to minimize the package size
  • to avoid naming conflicts

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

Sort of. Users can still use those 3 packages, but they need to make sure to use the exact version. Otherwise, simply install the package and rename the imports.

@heroui/framer-utils will be merged to @heroui/motion

📝 Additional Information

Copy link

changeset-bot bot commented Jan 26, 2025

🦋 Changeset detected

Latest commit: 428f88e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 56 packages
Name Type
@heroui/internationalized-date Patch
@heroui/use-aria-multiselect Patch
@heroui/scroll-shadow Patch
@heroui/react-aria-i18n Patch
@heroui/autocomplete Patch
@heroui/number-input Patch
@heroui/dom-animation Patch
@heroui/breadcrumbs Patch
@heroui/date-picker Patch
@heroui/date-input Patch
@heroui/pagination Patch
@heroui/accordion Patch
@heroui/input-otp Patch
@heroui/use-pagination Patch
@heroui/calendar Patch
@heroui/checkbox Patch
@heroui/dropdown Patch
@heroui/progress Patch
@heroui/skeleton Patch
@heroui/divider Patch
@heroui/listbox Patch
@heroui/popover Patch
@heroui/snippet Patch
@heroui/spinner Patch
@heroui/tooltip Patch
@heroui/avatar Patch
@heroui/button Patch
@heroui/drawer Patch
@heroui/navbar Patch
@heroui/ripple Patch
@heroui/select Patch
@heroui/slider Patch
@heroui/spacer Patch
@heroui/switch Patch
@heroui/alert Patch
@heroui/badge Patch
@heroui/image Patch
@heroui/input Patch
@heroui/modal Patch
@heroui/radio Patch
@heroui/table Patch
@heroui/toast Patch
@heroui/card Patch
@heroui/chip Patch
@heroui/code Patch
@heroui/form Patch
@heroui/link Patch
@heroui/menu Patch
@heroui/tabs Patch
@heroui/user Patch
@heroui/system-rsc Patch
@heroui/motion Patch
@heroui/kbd Patch
@heroui/system Patch
@heroui/react Patch
@heroui/aria-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
heroui ❌ Failed (Inspect) Feb 27, 2025 5:53am
heroui-sb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 5:53am

Copy link
Contributor

coderabbitai bot commented Jan 26, 2025

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

178 files out of 285 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@wingkwong wingkwong added this to the v2.7.0 milestone Jan 26, 2025
@jrgarciadev
Copy link
Member

@wingkwong please check build on Vercel
CleanShot 2025-02-05 at 17 41 57@2x

Copy link

pkg-pr-new bot commented Feb 27, 2025

Open in Stackblitz

@heroui/accordion

npm i https://pkg.pr.new/@heroui/accordion@4655

@heroui/alert

npm i https://pkg.pr.new/@heroui/alert@4655

@heroui/autocomplete

npm i https://pkg.pr.new/@heroui/autocomplete@4655

@heroui/avatar

npm i https://pkg.pr.new/@heroui/avatar@4655

@heroui/badge

npm i https://pkg.pr.new/@heroui/badge@4655

@heroui/breadcrumbs

npm i https://pkg.pr.new/@heroui/breadcrumbs@4655

@heroui/button

npm i https://pkg.pr.new/@heroui/button@4655

@heroui/calendar

npm i https://pkg.pr.new/@heroui/calendar@4655

@heroui/card

npm i https://pkg.pr.new/@heroui/card@4655

@heroui/checkbox

npm i https://pkg.pr.new/@heroui/checkbox@4655

@heroui/chip

npm i https://pkg.pr.new/@heroui/chip@4655

@heroui/code

npm i https://pkg.pr.new/@heroui/code@4655

@heroui/date-picker

npm i https://pkg.pr.new/@heroui/date-picker@4655

@heroui/date-input

npm i https://pkg.pr.new/@heroui/date-input@4655

@heroui/divider

npm i https://pkg.pr.new/@heroui/divider@4655

@heroui/drawer

npm i https://pkg.pr.new/@heroui/drawer@4655

@heroui/dropdown

npm i https://pkg.pr.new/@heroui/dropdown@4655

@heroui/form

npm i https://pkg.pr.new/@heroui/form@4655

@heroui/image

npm i https://pkg.pr.new/@heroui/image@4655

@heroui/input

npm i https://pkg.pr.new/@heroui/input@4655

@heroui/input-otp

npm i https://pkg.pr.new/@heroui/input-otp@4655

@heroui/kbd

npm i https://pkg.pr.new/@heroui/kbd@4655

@heroui/link

npm i https://pkg.pr.new/@heroui/link@4655

@heroui/listbox

npm i https://pkg.pr.new/@heroui/listbox@4655

@heroui/menu

npm i https://pkg.pr.new/@heroui/menu@4655

@heroui/modal

npm i https://pkg.pr.new/@heroui/modal@4655

@heroui/navbar

npm i https://pkg.pr.new/@heroui/navbar@4655

@heroui/number-input

npm i https://pkg.pr.new/@heroui/number-input@4655

@heroui/pagination

npm i https://pkg.pr.new/@heroui/pagination@4655

@heroui/popover

npm i https://pkg.pr.new/@heroui/popover@4655

@heroui/progress

npm i https://pkg.pr.new/@heroui/progress@4655

@heroui/radio

npm i https://pkg.pr.new/@heroui/radio@4655

@heroui/ripple

npm i https://pkg.pr.new/@heroui/ripple@4655

@heroui/scroll-shadow

npm i https://pkg.pr.new/@heroui/scroll-shadow@4655

@heroui/select

npm i https://pkg.pr.new/@heroui/select@4655

@heroui/skeleton

npm i https://pkg.pr.new/@heroui/skeleton@4655

@heroui/slider

npm i https://pkg.pr.new/@heroui/slider@4655

@heroui/snippet

npm i https://pkg.pr.new/@heroui/snippet@4655

@heroui/spacer

npm i https://pkg.pr.new/@heroui/spacer@4655

@heroui/spinner

npm i https://pkg.pr.new/@heroui/spinner@4655

@heroui/switch

npm i https://pkg.pr.new/@heroui/switch@4655

@heroui/table

npm i https://pkg.pr.new/@heroui/table@4655

@heroui/tabs

npm i https://pkg.pr.new/@heroui/tabs@4655

@heroui/toast

npm i https://pkg.pr.new/@heroui/toast@4655

@heroui/tooltip

npm i https://pkg.pr.new/@heroui/tooltip@4655

@heroui/user

npm i https://pkg.pr.new/@heroui/user@4655

@heroui/react

npm i https://pkg.pr.new/@heroui/react@4655

@heroui/system

npm i https://pkg.pr.new/@heroui/system@4655

@heroui/system-rsc

npm i https://pkg.pr.new/@heroui/system-rsc@4655

@heroui/theme

npm i https://pkg.pr.new/@heroui/theme@4655

@heroui/aria-utils

npm i https://pkg.pr.new/@heroui/aria-utils@4655

@heroui/dom-animation

npm i https://pkg.pr.new/@heroui/dom-animation@4655

@heroui/react-rsc-utils

npm i https://pkg.pr.new/@heroui/react-rsc-utils@4655

@heroui/react-utils

npm i https://pkg.pr.new/@heroui/react-utils@4655

@heroui/shared-icons

npm i https://pkg.pr.new/@heroui/shared-icons@4655

@heroui/shared-utils

npm i https://pkg.pr.new/@heroui/shared-utils@4655

@heroui/stories-utils

npm i https://pkg.pr.new/@heroui/stories-utils@4655

@heroui/test-utils

npm i https://pkg.pr.new/@heroui/test-utils@4655

@heroui/use-aria-accordion

npm i https://pkg.pr.new/@heroui/use-aria-accordion@4655

@heroui/use-aria-accordion-item

npm i https://pkg.pr.new/@heroui/use-aria-accordion-item@4655

@heroui/use-aria-button

npm i https://pkg.pr.new/@heroui/use-aria-button@4655

@heroui/use-aria-link

npm i https://pkg.pr.new/@heroui/use-aria-link@4655

@heroui/use-aria-modal-overlay

npm i https://pkg.pr.new/@heroui/use-aria-modal-overlay@4655

@heroui/use-aria-multiselect

npm i https://pkg.pr.new/@heroui/use-aria-multiselect@4655

@heroui/use-callback-ref

npm i https://pkg.pr.new/@heroui/use-callback-ref@4655

@heroui/use-clipboard

npm i https://pkg.pr.new/@heroui/use-clipboard@4655

@heroui/use-data-scroll-overflow

npm i https://pkg.pr.new/@heroui/use-data-scroll-overflow@4655

@heroui/use-disclosure

npm i https://pkg.pr.new/@heroui/use-disclosure@4655

@heroui/use-draggable

npm i https://pkg.pr.new/@heroui/use-draggable@4655

@heroui/use-image

npm i https://pkg.pr.new/@heroui/use-image@4655

@heroui/use-infinite-scroll

npm i https://pkg.pr.new/@heroui/use-infinite-scroll@4655

@heroui/use-intersection-observer

npm i https://pkg.pr.new/@heroui/use-intersection-observer@4655

@heroui/use-is-mobile

npm i https://pkg.pr.new/@heroui/use-is-mobile@4655

@heroui/use-is-mounted

npm i https://pkg.pr.new/@heroui/use-is-mounted@4655

@heroui/use-measure

npm i https://pkg.pr.new/@heroui/use-measure@4655

@heroui/use-pagination

npm i https://pkg.pr.new/@heroui/use-pagination@4655

@heroui/use-real-shape

npm i https://pkg.pr.new/@heroui/use-real-shape@4655

@heroui/use-ref-state

npm i https://pkg.pr.new/@heroui/use-ref-state@4655

@heroui/use-resize

npm i https://pkg.pr.new/@heroui/use-resize@4655

@heroui/use-safe-layout-effect

npm i https://pkg.pr.new/@heroui/use-safe-layout-effect@4655

@heroui/use-scroll-position

npm i https://pkg.pr.new/@heroui/use-scroll-position@4655

@heroui/use-ssr

npm i https://pkg.pr.new/@heroui/use-ssr@4655

@heroui/use-theme

npm i https://pkg.pr.new/@heroui/use-theme@4655

@heroui/use-update-effect

npm i https://pkg.pr.new/@heroui/use-update-effect@4655

commit: 428f88e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💥 Type: Breaking Change This PR includes breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Mitigate need for users to keep @internationalized/date version in sync with NextUI
2 participants