Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support tailwindcss v4 #4656

Open
wants to merge 50 commits into
base: beta/release-next
Choose a base branch
from
Open

Conversation

winchesHe
Copy link
Member

@winchesHe winchesHe commented Jan 26, 2025

Closes #4644

Description

The current migration is working fine with tailwindcss js config.

It won't be released that soon because it has a lot of breaking changes.

Need to update

  1. tailwind-merge upgrade ✅
  2. codemod support heroui plugin transform to css file

Migration steps

  1. Follow the official upgrade guide https://tailwindcss.com/docs/upgrade-guide
  2. Install the preview version feat: support tailwindcss v4 #4656 (comment)
  3. Use heroui with @config "path/to/tailwindcss"

Heroui template for tailwindcss v4

heroui-inc/vite-template#10

Copy link

changeset-bot bot commented Jan 26, 2025

⚠️ No Changeset found

Latest commit: 63afa9a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
heroui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 2:24pm
heroui-sb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 2:24pm

Copy link
Contributor

coderabbitai bot commented Jan 26, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (5)
  • main
  • canary
  • fix/.*
  • chore/.*
  • feat/.*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@wingkwong wingkwong changed the title Feat/tailwindcss v4 feat: support tailwindcss v4 Jan 28, 2025
@brandonhenness
Copy link

Currently, I'm trying to install directly from the feat/tailwindcss-v4 branch, but it's taking FOREVER. If I manage to get it working, I'll come back and let you know.

I was not able to get this to work either.

If this doesn't work, perhaps Heroui could merge these changes into the beta branch and create a beta dist-tag on npm?

@winchesHe what are the chances of getting a beta dist-tag on npm once this is merged with the beta/release-next branch?

@Franac1
Copy link

Franac1 commented Feb 19, 2025

Currently, I'm trying to install directly from the feat/tailwindcss-v4 branch, but it's taking FOREVER. If I manage to get it working, I'll come back and let you know.

I was not able to get this to work either.

If this doesn't work, perhaps Heroui could merge these changes into the beta branch and create a beta dist-tag on npm?

@winchesHe what are the chances of getting a beta dist-tag on npm once this is merged with the beta/release-next branch?

Thank you for saving me time.
I'm trying to use their killer date range picker component. I can't find anywhere else as near as good as theirs.
I really hope they start supporting tw v4.

@winchesHe
Copy link
Member Author

winchesHe commented Feb 19, 2025

@winchesHe what are the chances of getting a beta dist-tag on npm once this is merged with the beta/release-next branch?

Once merged will release a latest beta version in npm

@winchesHe
Copy link
Member Author

winchesHe commented Feb 19, 2025

tailwindlabs/tailwindcss#16664 related to ease-out important modifier issue

@christophmeise
Copy link

When I use any of these preview versions I get an runtime error:

Parsing css source code failed
  2979 |   }
  2980 |   .w-\[calc\(100\%_-_var\(spacing\.6\)\)\] {
> 2981 |     width: calc(100% - var(spacing.6));
       |                             ^
  2982 |   }
  2983 |   .w-\[calc\(2623\/16\*1rem\)\] {
  2984 |     width: calc(2623 / 16 * 1rem);

Unexpected token Ident("spacing") at [project]/apps/nextjs/src/styles/globals.css:2980:28

I can confirm that this error goes away as soon as I remove the heroui content import from the tailwind config: ../../node_modules/@heroui/theme/dist/**/*.{js,ts,jsx,tsx}
I also removed all CSS and plugins to confirm that this is a problem with heroui.

Using Tailwind 4.0.9, Nextjs 15.0.2 and tried both of the latest beta preview versions. I checked the implementation of the vite example and I am doing it exactly like that.

@winchesHe
Copy link
Member Author

When I use any of these preview versions I get an runtime error:

Parsing css source code failed
  2979 |   }
  2980 |   .w-\[calc\(100\%_-_var\(spacing\.6\)\)\] {
> 2981 |     width: calc(100% - var(spacing.6));
       |                             ^
  2982 |   }
  2983 |   .w-\[calc\(2623\/16\*1rem\)\] {
  2984 |     width: calc(2623 / 16 * 1rem);

Unexpected token Ident("spacing") at [project]/apps/nextjs/src/styles/globals.css:2980:28

I can confirm that this error goes away as soon as I remove the heroui content import from the tailwind config: ../../node_modules/@heroui/theme/dist/**/*.{js,ts,jsx,tsx} I also removed all CSS and plugins to confirm that this is a problem with heroui.

Using Tailwind 4.0.9, Nextjs 15.0.2 and tried both of the latest beta preview versions. I checked the implementation of the vite example and I am doing it exactly like that.

Fixed in the latest version https://github.com/heroui-inc/heroui/runs/37994128721

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💥 Type: Breaking Change This PR includes breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]Tailwind v4 support.