fix(select): pass form prop to hidden-select #4854

smozely · 2025-02-18T10:09:39Z

📝 Description

fixes an issue where the select component couldn't be when passing a form as a prop. which works for the other components exposed from Hero URI

⛳️ Current behavior (updates)

the form prop passed to a select component was just silently dropped.

🚀 New behavior

the form prop passed to a select component is now passed down to the hidden select component or the hidden input for when the list of items is greater than 300

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

Summary by CodeRabbit

New Features
- Enhanced form integration for selection inputs, enabling hidden selections to be explicitly linked to their corresponding form for improved submission handling.
- Introduced a new property to facilitate better integration of hidden select components with form handling mechanisms.

coderabbitai · 2025-02-18T10:09:51Z

Walkthrough

The changes add a new optional property, form, to multiple interfaces and function signatures within the select components. This property is passed from parent components through hooks to the underlying hidden <input>, enabling the component to associate the input with a specific form. The update affects both the HiddenSelect component and its related hooks, ensuring that the form value is included in the rendered element and in the object returned by helper functions.

Changes

File(s)	Change Summary
packages/.../hidden-select.tsx	Added the optional `form?: string` property to interfaces (`AriaHiddenSelectProps`, `HiddenSelectProps`, and `AriaHiddenSelectOptions`); updated function signatures for `useHiddenSelect` and `HiddenSelect` to include and forward the `form` property.
packages/.../use-select.ts	Added the `form` property extraction in `getHiddenSelectProps` and included it in the returned object, ensuring the hidden select component receives the form reference.
.changeset/four-terms-relax.md	Added a dependency for `"@heroui/select": patch` and noted that the form property should be passed to a hidden select component.

Sequence Diagram(s)

sequenceDiagram
    participant App as Application
    participant HS as HiddenSelect Component
    participant HSHook as useHiddenSelect Hook
    participant Input as Hidden <input>
    
    App->>HS: Pass props (including form)
    HS->>HSHook: Call useHiddenSelect with props & form
    HSHook-->>HS: Return selectProps containing form
    HS->>Input: Render hidden input with form attribute

Suggested reviewers

wingkwong
jrgarciadev

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bdcf3e5 and c333afc.

📒 Files selected for processing (1)

packages/components/select/src/use-select.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

packages/components/select/src/use-select.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

changeset-bot · 2025-02-18T10:09:52Z

🦋 Changeset detected

Latest commit: c333afc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@heroui/select	Patch
@heroui/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2025-02-18T10:09:52Z

@smozely is attempting to deploy a commit to the HeroUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

vercel · 2025-02-18T15:01:35Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
heroui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 24, 2025 11:23am
heroui-sb	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 24, 2025 11:23am

.changeset/four-terms-relax.md

pkg-pr-new · 2025-02-18T15:09:42Z

Open in Stackblitz

@heroui/accordion

npm i https://pkg.pr.new/@heroui/accordion@4854

@heroui/alert

npm i https://pkg.pr.new/@heroui/alert@4854

@heroui/autocomplete

npm i https://pkg.pr.new/@heroui/autocomplete@4854

@heroui/avatar

npm i https://pkg.pr.new/@heroui/avatar@4854

@heroui/badge

npm i https://pkg.pr.new/@heroui/badge@4854

@heroui/breadcrumbs

npm i https://pkg.pr.new/@heroui/breadcrumbs@4854

@heroui/button

npm i https://pkg.pr.new/@heroui/button@4854

@heroui/calendar

npm i https://pkg.pr.new/@heroui/calendar@4854

@heroui/card

npm i https://pkg.pr.new/@heroui/card@4854

@heroui/checkbox

npm i https://pkg.pr.new/@heroui/checkbox@4854

@heroui/chip

npm i https://pkg.pr.new/@heroui/chip@4854

@heroui/code

npm i https://pkg.pr.new/@heroui/code@4854

@heroui/date-input

npm i https://pkg.pr.new/@heroui/date-input@4854

@heroui/date-picker

npm i https://pkg.pr.new/@heroui/date-picker@4854

@heroui/divider

npm i https://pkg.pr.new/@heroui/divider@4854

@heroui/drawer

npm i https://pkg.pr.new/@heroui/drawer@4854

@heroui/dropdown

npm i https://pkg.pr.new/@heroui/dropdown@4854

@heroui/form

npm i https://pkg.pr.new/@heroui/form@4854

@heroui/image

npm i https://pkg.pr.new/@heroui/image@4854

@heroui/input

npm i https://pkg.pr.new/@heroui/input@4854

@heroui/input-otp

npm i https://pkg.pr.new/@heroui/input-otp@4854

@heroui/kbd

npm i https://pkg.pr.new/@heroui/kbd@4854

@heroui/link

npm i https://pkg.pr.new/@heroui/link@4854

@heroui/listbox

npm i https://pkg.pr.new/@heroui/listbox@4854

@heroui/menu

npm i https://pkg.pr.new/@heroui/menu@4854

@heroui/modal

npm i https://pkg.pr.new/@heroui/modal@4854

@heroui/navbar

npm i https://pkg.pr.new/@heroui/navbar@4854

@heroui/number-input

npm i https://pkg.pr.new/@heroui/number-input@4854

@heroui/pagination

npm i https://pkg.pr.new/@heroui/pagination@4854

@heroui/popover

npm i https://pkg.pr.new/@heroui/popover@4854

@heroui/progress

npm i https://pkg.pr.new/@heroui/progress@4854

@heroui/radio

npm i https://pkg.pr.new/@heroui/radio@4854

@heroui/ripple

npm i https://pkg.pr.new/@heroui/ripple@4854

@heroui/scroll-shadow

npm i https://pkg.pr.new/@heroui/scroll-shadow@4854

@heroui/select

npm i https://pkg.pr.new/@heroui/select@4854

@heroui/skeleton

npm i https://pkg.pr.new/@heroui/skeleton@4854

@heroui/slider

npm i https://pkg.pr.new/@heroui/slider@4854

@heroui/snippet

npm i https://pkg.pr.new/@heroui/snippet@4854

@heroui/spacer

npm i https://pkg.pr.new/@heroui/spacer@4854

@heroui/spinner

npm i https://pkg.pr.new/@heroui/spinner@4854

@heroui/switch

npm i https://pkg.pr.new/@heroui/switch@4854

@heroui/table

npm i https://pkg.pr.new/@heroui/table@4854

@heroui/tabs

npm i https://pkg.pr.new/@heroui/tabs@4854

@heroui/toast

npm i https://pkg.pr.new/@heroui/toast@4854

@heroui/tooltip

npm i https://pkg.pr.new/@heroui/tooltip@4854

@heroui/user

npm i https://pkg.pr.new/@heroui/user@4854

@heroui/react

npm i https://pkg.pr.new/@heroui/react@4854

@heroui/system

npm i https://pkg.pr.new/@heroui/system@4854

@heroui/system-rsc

npm i https://pkg.pr.new/@heroui/system-rsc@4854

@heroui/theme

npm i https://pkg.pr.new/@heroui/theme@4854

@heroui/use-aria-accordion

npm i https://pkg.pr.new/@heroui/use-aria-accordion@4854

@heroui/use-aria-accordion-item

npm i https://pkg.pr.new/@heroui/use-aria-accordion-item@4854

@heroui/use-aria-button

npm i https://pkg.pr.new/@heroui/use-aria-button@4854

@heroui/use-aria-link

npm i https://pkg.pr.new/@heroui/use-aria-link@4854

@heroui/use-aria-modal-overlay

npm i https://pkg.pr.new/@heroui/use-aria-modal-overlay@4854

@heroui/use-aria-multiselect

npm i https://pkg.pr.new/@heroui/use-aria-multiselect@4854

@heroui/use-callback-ref

npm i https://pkg.pr.new/@heroui/use-callback-ref@4854

@heroui/use-clipboard

npm i https://pkg.pr.new/@heroui/use-clipboard@4854

@heroui/use-data-scroll-overflow

npm i https://pkg.pr.new/@heroui/use-data-scroll-overflow@4854

@heroui/use-disclosure

npm i https://pkg.pr.new/@heroui/use-disclosure@4854

@heroui/use-draggable

npm i https://pkg.pr.new/@heroui/use-draggable@4854

@heroui/use-image

npm i https://pkg.pr.new/@heroui/use-image@4854

@heroui/use-infinite-scroll

npm i https://pkg.pr.new/@heroui/use-infinite-scroll@4854

@heroui/use-intersection-observer

npm i https://pkg.pr.new/@heroui/use-intersection-observer@4854

@heroui/use-is-mobile

npm i https://pkg.pr.new/@heroui/use-is-mobile@4854

@heroui/use-is-mounted

npm i https://pkg.pr.new/@heroui/use-is-mounted@4854

@heroui/use-measure

npm i https://pkg.pr.new/@heroui/use-measure@4854

@heroui/use-pagination

npm i https://pkg.pr.new/@heroui/use-pagination@4854

@heroui/use-real-shape

npm i https://pkg.pr.new/@heroui/use-real-shape@4854

@heroui/use-ref-state

npm i https://pkg.pr.new/@heroui/use-ref-state@4854

@heroui/use-resize

npm i https://pkg.pr.new/@heroui/use-resize@4854

@heroui/use-safe-layout-effect

npm i https://pkg.pr.new/@heroui/use-safe-layout-effect@4854

@heroui/use-scroll-position

npm i https://pkg.pr.new/@heroui/use-scroll-position@4854

@heroui/use-ssr

npm i https://pkg.pr.new/@heroui/use-ssr@4854

@heroui/use-theme

npm i https://pkg.pr.new/@heroui/use-theme@4854

@heroui/use-update-effect

npm i https://pkg.pr.new/@heroui/use-update-effect@4854

@heroui/aria-utils

npm i https://pkg.pr.new/@heroui/aria-utils@4854

@heroui/dom-animation

npm i https://pkg.pr.new/@heroui/dom-animation@4854

@heroui/framer-utils

npm i https://pkg.pr.new/@heroui/framer-utils@4854

@heroui/react-rsc-utils

npm i https://pkg.pr.new/@heroui/react-rsc-utils@4854

@heroui/react-utils

npm i https://pkg.pr.new/@heroui/react-utils@4854

@heroui/shared-icons

npm i https://pkg.pr.new/@heroui/shared-icons@4854

@heroui/shared-utils

npm i https://pkg.pr.new/@heroui/shared-utils@4854

@heroui/stories-utils

npm i https://pkg.pr.new/@heroui/stories-utils@4854

@heroui/test-utils

npm i https://pkg.pr.new/@heroui/test-utils@4854

commit: c333afc

jrgarciadev

Thanks! @smozely

* chore: org name change (#4596) * chore: update brand name (#4600) * fix(calendar): function components cannot be given refs (#4614) * docs(modal): fix small typos and add clarifying language (#4629) * chore(deps): bump RA versions (#4611) * chore(deps): bump RA versions * chore(deps): bump @internationalized/date * chore(docs): update RA versions * chore(docs): update versions * chore(docs): use string type * chore(deps): update @react-types versions * refactor(docs): undo version change since they will be removed in another PR * feat: tailwind variants upgrade (#4386) * feat: tailwind variants upgrade * chore: restore npmrc * chore: adjust pkgs * fix: versions * fix: lock file * chore(changeset): update package name * chore(deps): use fixed version * fix(test): incorrect package name --------- Co-authored-by: աӄա <[email protected]> * feat: add fn win alt keys (#4638) * feat: add new keys * feat: add new keys * chore: update docs & storybook as well --------- Co-authored-by: WK Wong <[email protected]> * fix(use-image): load images after props change (#4523) * fix(use-image): load image after props change * chore(changeset): add changeset * refactor(use-image): remove unused props * feat(use-image): add test case * fix(use-image): apply useCallback to load & remove status check * chore(changeset): update package name * feat: global labelPlacement prop (#4346) * feat: adding the support for labelPlacement globally * chore: reafctoring * chore: updating the dependency * chore(changeset): update package name * chore: adding Marcus's suggestions --------- Co-authored-by: աӄա <[email protected]> * fix(form): use native as default validation behavior (#4425) * fix(form): use native as default validation behavior * docs(form): delete explicit validationBehavior=native * test(form): adjusted form test validation behaviors * chore(form): adjusted stories with forms * chore(changeset): changed form default validation behavior to native * chore(changeset): removed packages with only test changes * chore(changeset): change to patch * chore(changeset): update package name * refactor(docs): update package name * refactor(docs): update to heroui --------- Co-authored-by: աӄա <[email protected]> * feat(spinner): new spinner variants (#4555) * refactor(spinner): add default variant * feature(spinner): add gradient variant * feature(spinner): add dots variant * feature(spinner): add dots-blink variant * feature(spinner): add spinner-bars * chore(spinner): add variants storybook * chore: adding variants to docs * chore: simplyfying the styles and modifying docs * chore: nits * chore: updating the dots and dots-blink animation * chore: nits * chore: adding Marcus' suggestions * chore: adding Marcus's suggestions * chore: adding junior's suggestions --------- Co-authored-by: Maharshi Alpesh <[email protected]> * fix: rename wrapper to tab wrapper (#4636) * fix: rename wrapper to tab wrapper * docs: update * docs: update * docs: update * fix: rename wrapper to tab wrapper * refactor: remove feature request from issue template (#4661) * refactor(.github): remove feature request template * refactor(.github): add a link to redirect to discussion (feature request category) * docs(table): include TS examples to show Selection type usage (#4793) * fix(listbox): unexpected scrollShadow on virtualized listbox (#4784) * fix(listbox): add scroll height & scroll top to listbox * fix(use-data-scroll-overflow): handle scrollHeight & scrollTop in virtualization * chore(changeset): add changeset * refactor(theme): replace left & right by start & end to support RTL (#4782) * fix(date-picker): deprecate dateInputClassNames (#4780) * chore(date-picker): add missing slots comments * fix(date-picker): remove dateInputClassNames * fix(date-picker): use classNames instead of dateInputClassNames * chore(docs): add missing attributes * fix(date-picker): use classNames instead of dateInputClassNames * feat(changeset): add changeset * fix(docs): broken type * refactor(navbar): remove dropdown menu width (#4757) * refactor: remove dropdown menu width * refactor: shorter description * refactor: rename instances of NextUI to Hero UI (#4645) * docs: use the correct org for `img.shields.io` license in README * docs: update opencollective org name * docs: use correct org name in site footer * docs: update image urls for heroui pro sections * docs: update laravel installation keywords in route config * docs: add `heroui` tag to `Introducing HeroUI` blog post * fix: use correct names in `plop/components/src` templates * chore: add empty changeset * fix: revert image urls back to `nextuipro.nyc3.cdn.digitaloceanspaces...` * chore: undo footer change * chore: update incorrect brand name * chore(docs): nextui -> heroui --------- Co-authored-by: աӄա <[email protected]> * fix(input): missing clear button with file input type (#4599) * fix(theme): sync with input theme on labelPlacement (#4597) * fix(theme): sync with input theme on labelPlacement * chore(select): revise width for labelPlacement * chore(changeset): add changeset * test(input): input interaction tests (#4579) * test(input): user interaction tests * test(input): missing act wrappers --------- Co-authored-by: WK Wong <[email protected]> * fix(calendar): rtl navigation (#4565) * fix(calendar): rtl navigation * chore(changeset): fixed reverse behavior of NextButton and PrevButton in the RTL calendar * chore(changeset): update package name * refactor(calendar): prefer isRTL and use className in theme package instead * chore(changeset): add theme package as well * chore(calendar): add min theme package to 2.4.7 --------- Co-authored-by: աӄա <[email protected]> * refactor: remove unnecessary className passing to tv and make naming consistent (#4558) * refactor: remove unnecessary className passing to tv * refactor(button): move styles to getButtonProps * refactor: rename classNames to styles to keep the naming consistent * fix: deprecation warning triggered by internal onClick (#4557) * fix(use-aria-link): onClick deprecation warning * fix(use-aria-button): onClick deprecation warning * feat(changeset): add changeset * fix(use-aria-button): incorrect prop name * chore(changeset): update package name * ci: add pkg pr new (#4540) * ci: add pkg pr new * ci: add pkg pr new * chore(workflow): update repo name --------- Co-authored-by: աӄա <[email protected]> * chore(docs): remove shouldBlockScroll prop in Tooltip page (#4539) * fix(use-pagination): controlled page after delay (#4536) * fix(use-pagination): add page to dependency for scrollTo * feat(changeset): add changeset * chore(changeset): update package name * fix(tooltip): accessing element.ref was removed in React 19 issue (#4531) * fix(tooltip): accessing element.ref was removed in React 19 issue * chore(changeset): update package name * fix: correctly dismissable default value (#4524) * fix: correctly dismissable default value * fix: correctly dismissable default value * chore(changeset): update package name --------- Co-authored-by: աӄա <[email protected]> * fix(theme): input height in innerWrapper in Select (#4512) * fix(select): fix input height #4321 * chore(select): changed package name in changeset to theme * chore(select): updated changeset message * chore(changeset): update package name --------- Co-authored-by: աӄա <[email protected]> * fix: inert value in next15 (#4491) * feat: add post install * feat: add postinstall * feat: add postinstall * fix: type * fix: type * fix: next version * chore(changeset): update package name --------- Co-authored-by: աӄա <[email protected]> * refactor: remove cursor-hit in hiddenInputClasses (#4474) * refactor: remove cursor-hit in hiddenInputClasses * Create lazy-ants-exercise.md * chore(changeset): update package name --------- Co-authored-by: աӄա <[email protected]> * feat(table): virtualization (#4285) * feat: baseline virtualization for table * merge branch canary * fix: table layout * fix: calc header height w layouteffect to offset padding * Merge branch 'canary' into feat/eng-1633-virtualization-for-table * chore: remove unused files and comments * chore: add missing package * feat: add shouldVirtualize conditional to render virtualized-table * feat: update docs for table * feat: use wrapper to support theme styles * chore: add changeset * chore(changeset): update package name * chore(deps): pnpm-lock.yaml * fix(table): outdated package name * chore(changeset): add issue number * fix(deps): keep the version consistent with other components * fix(table): incorrect displayName * refactor(table): use VirtualizedTemplate * chore(deps): bump `@tanstack/react-virtua` * chore(deps): typecheck issue * fix(table): do not use any type * chore: remove auto virtualization --------- Co-authored-by: աӄա <[email protected]> Co-authored-by: Junior Garcia <[email protected]> * feat(toast): introduce Toast component (#4437) * feat: initial commit * chore: adding the animation * chore: nits * chore: fixes and adding draft1 of stories * chore: adding the docs draft * chore: adding the swiping interaction for toast removal * chore: adding the tests * fix: improving the progress bar logix * chore: refactoring and refining the animations * fix: making the animations compatible with the positons * chore: fixing the styles * chore: modifying the animations * chore: improving the animations * chore: adding the decorator to the story-book * chore: fixing the animations and positions * fix: handle expand region on touch * feat: adding the promises support * chore: updating the styles * chore: improving styles * chore: styles correction * fix: adding junior's suggestions * chore: correcting styles * fix: fixing the timer behavior * chore: adding the spinner to the toast * chore: full width for mobile * chore: modifying styles * chore: fixing the positions on smaller devices * chore: adding story with description * chore: adding credits for sonner * fix: adding junior's suggestions * chore: adding the exit animation * fix: adding junior's suggestions * chore: improving the swipe animations * fix: fixing the swipe animations on touch * chore: adding tests * chore: adding swipe threshild and initial position variable * fix: fixing autoclose in timeout * chore: modifying the docs * chore: fixing the conflict * chore: adding marcus' suggestions * chore: adding the bottom animations * chore: modying docs * chore: removing nextui references * chore: adding info about the provider * chore: updating the docs * chore: versions in package.json * chore: nits * chore: adding junior's suggestions * chore: nits * fix: applying junior's suggestions * chore: adding junior's suggestions * chore: using domMax * fix: adding Marcus's suggestions * chore: add global toast props and custom close icon * chore: adding the defaultTimout provider prop * chore: modifying defaultTimeout * chore: nits * fix: adding Marcus' suggestions * chore: fixing bg * chore(deps): bump RA deps * fix: fixing the color discrepancy due to the timer * chore: moving the kapan ai to the left side * refactor(toast): update author * chore: nit * chore: improvements * chore: updating the solid variant --------- Co-authored-by: Junior Garcia <[email protected]> Co-authored-by: WK Wong <[email protected]> * fix(docs): correct Tab usage example (#4821) * chore(docs): add note itemHeight for virtualization (#4822) * chore(docs): add note itemHeight for virtualization * fix: format * fix(docs): fix horizontal scrolling example in scroll-shadow (#4820) * refactor: update author in package.json (#4800) * feat(button): export PressEvent for onPress event typing (#4819) * fix(docs): failed to install dependencies in StackBlitz (#4639) * chore(Docs): remove step 2 from "Using use-theme-hook" (#4797) * fix(docs): incorrect code Modal placement (#4652) * docs: update DatePicker example to remove "time" label as time selection is not supported in this example (#4443) * feat(button): export PressEvent for onPress event typing * revert unnecessary changes * chore: format --------- Co-authored-by: աӄա <[email protected]> Co-authored-by: Praharsh Bhatt <[email protected]> * fix(listbox): pass missing press events to usePress (#4812) * fix(listbox): pass missing press events to usePress * feat(listbox): add test case for press event * chore(changeset): add changeset * fix(checkbox): inherit stroke in CheckboxIcon (#4811) * fix: `SelectItem`, `ListboxItem`, and `AutocompleteItem` not to accept `value` props (#4653) * fix(select): `SelectItem` does not accept value props * refactor: do not use the index as `key` * Update .changeset/light-hairs-draw.md * chore: remove unnecessary `value` props * chore: update changeset * refactor: remove unnecessary value prop --------- Co-authored-by: WK Wong <[email protected]> * fix: pkg package scope (#4823) * fix: pkg package scope * fix: pkg package scope * fix: pkg package scope * fix(theme): border radius in Table when isMultiSelectable (#4808) * fix(theme): border radius in Table when isMultiSelectable * chore(theme): added changeset (#4807) * chore: removing the kapa ai for toast doc page (#4833) * fix(accordion): add data-slot attributes to accordion (#4832) * fix(accordion): add data-slot attributes to accordion * chore --------- Co-authored-by: Hovannes Markarian <[email protected]> Co-authored-by: աӄա <[email protected]> * chore(docs): update versions (#4836) * docs(themes): adding theme generator (#4626) * chore: adding xylish's contributions + modifying styles * chore: nextui to heroui * chore: colors in theme generator * chore: radiuses, disable-opacity * chore: fixing the configuration box styles * chore: adding the showcase elemtents * chore: modifying styles * chore: adding the fonts * chore: adding the scaling * chore: removing the calendar * feat: adding the border-width * chore: modifying style for mobile * chore: modifying the styles * chore: removing the NextUI references + small bug fix * chore: adding coderabits reviews * fix: borderWidth not getting applied on breadcrumbs and input * chore: rebasing * chore: modifying the styles * chore: updating the styles for the smaller devices * chore: refactoring * chore: improvements * chore: making the fonts workable * chore: making the fonts workable * chore: modifying the swatch according to the theme * chore: adding the default selected template * chore: modifying mobile styles * chore: fixing the popover * chore: nit * fix: fixing the select styles * chore: modifying the mobile styles * chore: modifying the styles * fix: adding junior's suggestions * fix: fixing the breadcrumb * fix: adding junior's suggestions * feat: introduce NumberInput (#4475) * feat(number-field): init structure * feat(deps): add `@nextui-org/button` & `@react-types/button` * feat(theme): export number-field * feat(number-field): storybook init structure * feat(number-field): add NumberFieldHorizontalStepper * feat(number-field): add NumberFieldHorizontalStepper * feat(theme): init number field theme * feat(number-field): number-field draft * refactor(number-field): revise stepper icons * feat(shared-icons): add ChevronLeftIcon * feat(theme): stepperButton styles * feat(theme): number-field styles * fix(number-field): label layout * feat(number-field): vertical stepper wrapper * feat(number-field): use-number-field (wip) * feat(number-field): add data-direction * feat(theme): center the text if it is horizontal stepper * feat(number-field): add HorizontalStepper * feat(number-field): add HideStepper * chore(number-field): revise minValue & defaultValue * feat(docs): init number field structure * fix(theme): outside-left styles * refactor(theme): remove labelPlacement styles * refactor(number-field): remove labelContent logic * refactor(number-field): remove labelPlacement args * feat(number-field): helper text * feat(number-field): revise number field stories * feat(number-field): description * refactor(number-field): revise number field stories * feat(theme): numberFieldLabelClasses * fix(number-field): incorrect button props * fix(number-field): typing issue on stepper buttons * chore(number-field): add aria-label * refactor(number-field): merge props * fix(number-field): pass originalProps instead * chore(number-field): revise Required story args * feat(number-field): add WithStepValue & WithWheelDisabled & revise stories * chore(number-field): add label to Required * feat(docs): number-field doc page * fix(number-field): typing issue * fix(number-field): test cases * fix(number-field): user.keyboard & defaultValue * fix(number-field): should work with defaultValues * chore(number-field): add type: number * chore(number-field): remove hidden related code * fix(number-field): numeric value * chore(changeset): add changeset * feat(deps): add "@nextui-org/number-field" to docs * feat(react): export `@nextui-org/number-field` * feat(changeset): add @nextui-org/react * feat(docs): number-field examples * chore(number-field): use text instead * refactor(number-field): remove unnecessary filled-within * fix(number-field): test case * chore(number-field): remove aria-label for stepper buttons * feat(docs): add incrementAriaLabel & decrementAriaLabel to NumberField * chore(number-field): reorder WithFormatOptions * fix(deps): update number-field's peerDependencies & dependencies * feat(number-field): hidden input for holding numeric vaule * fix(docs): number field title * feat(docs): add format options to number field * chore(docs): revise number field content * chore(number-field): add type to useDOMRef * fix(number-field): clear button * fix(theme): clear button styles * refactor(theme): stepper button styles * chore(number-field): accept stepperButton class * fix(theme): helper wrapper padding * feat(deps): add `@react-aria/i18n` * fix(number-field): use locale from `@react-aria/i18n` * fix(deps): dependency order * fix(docs): incorrect command * chore(docs): remove type=number * chore(theme): add padding to stepper wrapper * fix(number-field): avoid resetting value * fix(number-field): storybook * chore(docs): remove custom impl * chore(docs): update docs code & content * chore(number-field): migrate to heroui * chore(number-field): migrate to heroui * chore(number-field): migrate to heroui * chore: rename to number input * fix(number-input): incorrect import * chore(docs): rename to number input * chore: change to number input * refactor(number-input): change label to amount * fix(docs): use heroui commands * chore(changeset): update package name * refactor(number-input): remove steps * refactor: remove helper text * feat(number-input): label placement * refactor(number-input): rename stepper * fix(theme): isClearable * feat(docs): add label placements * refactor(docs): update number-input content * fix(docs): incorrect file * feat(docs): add lablePlacement * refactor(docs): remove labelPlacement & startContent * refactor(docs): remove helperText * refactor(docs): remove helperText * refactor(docs): revise description * feat(number-input): add data-slot for stepper-wrapper * fix(number-input): test cases * fix(docs): unexpected change * refactor(number-input): update outdated info * fix(docs): coderabbitai comments * refactor: remove validationState * fix(docs): typo * chore(deps): remove unnecessary dep * chore(deps): bump RA versions * chore(number-input): apply latest labelPlacement change * refactor(number-input): update author * refactor(number-input): revise stepper wrapper alignment * refactor(number-input): stepper button styles * chore(number-input): add disableRipple * fix(theme): increase stepper button click area * fix(number-input): sync latest validationBehavior changes * fix(number-input): pass validationBehavior to useAriaNumberInput * chore(docs): add import react * chore(number-input): remove HorizontalStepper story * chore(number-input): enable ripple * fix(number-input): remove number type * refactor(theme): follow input clear button styles * feat(theme): add color for stepperButton * fix(theme): revise stepperButton size for outside & outside-left cases * fix(number-input): typo * chore(docs): update description for wheel * chore(theme): change opacity when pressed * chore(number-input): add disableRipple * Update .changeset/witty-flies-reflect.md * fix(theme): add hover opacity effect --------- Co-authored-by: Junior Garcia <[email protected]> * chore(docs): revised tags in doc routes for 2.7.0 (#4777) * chore(docs): remove last version update tags * chore(docs): add updated tag for 2.7.0 * chore(docs): updated table * chore(docs): update search meta * chore(docs): update github info * Merge branch 'canary' into docs/eng-2003 * chore(docs): update routes.json * chore(docs): update meta info * chore: improve theme builder * v2.7.0 * chore: v2.7.0 combined changeset * fix: changeset * fix: peer deps * feat: toast api improved * chore: toast styles improved * fix: toast styles * chore: toast width style changed * fix: changeset release * fix: changeset peerdeps * chore: toast styles improved * refactor(pagination): rtl (#4843) * refactor(pagination): rtl * chore(changeset): add changeset * feat: new spinner variant * fix(docs): popover shouldBlockScroll default value (#4851) * fix(select): select scroll content will close immediately when popover on click (#4849) * chore(select): update select deps * fix(select): select scroll content will close immediately when popover on click * chore(select): add .changeset file * chore(changeset): add issue number --------- Co-authored-by: աӄա <[email protected]> * feat(calendar): add firstDayOfWeek (#4852) * feat(calendar): add firstDayOfWeek * feat(docs): add firstDayOfWeek in Calendar docs * feat(calendar): add firstDayOfWeek to range calendar * feat(docs): add firstDayOfWeek to API table * feat: add firstDayOfWeek to date picker & date range picker * feat(docs): add firstDayOfWeek * feat(changeset): add changeset * feat: add firstDayOfWeek option in storybook * feat(docs): export firstDayOfWeek * chore(docs): update title * chore: spinner variants updated * feat: v2.7.0 blog * ci(changesets): version packages (#4601) Co-authored-by: Junior Garcia <[email protected]> * chore: manual release * fix(toast): fixing maxVisibleToasts, solid variant promise, promise timer (#4881) * fix: maxVisibleToasts functionality * chore: adding the changeset * fix: starting the toast timer when the promise is resolved * fix: spinner invisible in solid variants * fix(toast): shouldShowTimeoutProgess typo (#4858) * fix(toast): shouldShowTimeoutProgess typo * fix(toast): shouldShowTimeoutProgess typo * fix(select): pass form prop to hidden-select (#4854) * fix(select): pass form prop to hidden-select * chore(select): changeset * fix(spinner): Attempted to call useProviderContext() from the server (#4904) * fix(spinner): add banner in tsup.config.ts * chore(changeset): add changeset * chore(docs): update breaking changes in blog * chore(docs): handled in PR4905 * fix(number-input): onChange event in number input (#4907) * fix(number-input): onChange event in number input * chore(number-input): remove duplicate test case * fix(breadcrumb): broken start & end content (#4921) (#4922) * refactor: build process (#4909) * chore: update component description * chore: exclude stories-utils & test-utils * chore(utilities): remove unused info * chore(deps): pnpm-lock.yaml * fix: incorrect system & theme version in peerDependencies (#4901) * fix: incorrect system & theme version in peerDependencies * fix: incorrect system & theme version in peerDependencies * chore(changeset): add changeset * fix(changeset): remove `@heroui/stories-utils` and `@heroui/test-utils` from ignore list (#4939) * fix(docs): include .npmrc in sandbox (#4951) * fix(input): esc key to clear input value (#4892) * chore: theme generator credits * fix: blog date and spinner default variant * fix: #4850 Solve Pressing ESC doesn't clear input value * fix: #4850 code review change * fix: undo changes in apps/docs/content/blog/v2.7.0.mdx and add a test case for my changes * fix: run through the test cases successfully * fix: change md content * fix: using isClearable not clear the value * fix: add number-input clearable esc clear * fix: edit review problem * fix: delete unless file * chore(changeset): update changeset * fix: add inputProps.onKeyDown * fix: pressing ESC key in a read-only input not clear --------- Co-authored-by: Junior Garcia <[email protected]> Co-authored-by: աӄա <[email protected]> * ci(changesets): version packages (#4896) Co-authored-by: Junior Garcia <[email protected]> * v2.7.4 --------- Co-authored-by: աӄա <[email protected]> Co-authored-by: millmason <[email protected]> Co-authored-by: winches <[email protected]> Co-authored-by: Maharshi Alpesh <[email protected]> Co-authored-by: Peterl561 <[email protected]> Co-authored-by: Paul Ebose <[email protected]> Co-authored-by: Zarin <[email protected]> Co-authored-by: Shrinidhi Upadhyaya <[email protected]> Co-authored-by: Avan <[email protected]> Co-authored-by: Vincentius Roger Kuswara <[email protected]> Co-authored-by: Ryo Matsukawa <[email protected]> Co-authored-by: Praharsh Bhatt <[email protected]> Co-authored-by: Adrian Szarapow <[email protected]> Co-authored-by: Hova25 <[email protected]> Co-authored-by: Hovannes Markarian <[email protected]> Co-authored-by: Tsuki <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Steve Mosley <[email protected]> Co-authored-by: LinYongLu <[email protected]>

fix(select): pass form prop to hidden-select

624a8e3

smozely requested a review from jrgarciadev as a code owner February 18, 2025 10:09

vercel bot deployed to Preview – heroui February 18, 2025 15:04 View deployment

vercel bot deployed to Preview – heroui-sb February 18, 2025 15:06 View deployment

wingkwong requested changes Feb 18, 2025

View reviewed changes

.changeset/four-terms-relax.md Outdated Show resolved Hide resolved

chore(select): changeset

bdcf3e5

smozely force-pushed the fix/select_form_link branch from 31b14ab to bdcf3e5 Compare February 18, 2025 18:18

smozely requested a review from wingkwong February 18, 2025 18:19

Merge branch 'heroui-inc:canary' into fix/select_form_link

c333afc

wingkwong added this to the v2.7.3 milestone Feb 20, 2025

wingkwong approved these changes Feb 23, 2025

View reviewed changes

wingkwong assigned jrgarciadev Feb 23, 2025

vercel bot deployed to Preview – heroui February 24, 2025 11:21 View deployment

vercel bot deployed to Preview – heroui-sb February 24, 2025 11:23 View deployment

jrgarciadev approved these changes Feb 26, 2025

View reviewed changes

jrgarciadev merged commit 989cbe1 into heroui-inc:canary Feb 26, 2025
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(select): pass form prop to hidden-select #4854

fix(select): pass form prop to hidden-select #4854

smozely commented Feb 18, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 18, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

changeset-bot bot commented Feb 18, 2025 •

edited

Loading

vercel bot commented Feb 18, 2025

vercel bot commented Feb 18, 2025 •

edited

Loading

pkg-pr-new bot commented Feb 18, 2025 •

edited

Loading

jrgarciadev left a comment

fix(select): pass form prop to hidden-select #4854

fix(select): pass form prop to hidden-select #4854

Conversation

smozely commented Feb 18, 2025 • edited by coderabbitai bot Loading

📝 Description

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

coderabbitai bot commented Feb 18, 2025 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

changeset-bot bot commented Feb 18, 2025 • edited Loading

🦋 Changeset detected

vercel bot commented Feb 18, 2025

vercel bot commented Feb 18, 2025 • edited Loading

pkg-pr-new bot commented Feb 18, 2025 • edited Loading

jrgarciadev left a comment

Choose a reason for hiding this comment

smozely commented Feb 18, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 18, 2025 •

edited

Loading

changeset-bot bot commented Feb 18, 2025 •

edited

Loading

vercel bot commented Feb 18, 2025 •

edited

Loading

pkg-pr-new bot commented Feb 18, 2025 •

edited

Loading