Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[G++] support #24

Merged
merged 3 commits into from
Feb 7, 2024
Merged

[G++] support #24

merged 3 commits into from
Feb 7, 2024

Conversation

hexdae
Copy link
Owner

@hexdae hexdae commented Nov 17, 2023

Provide a way to create custom toolchains that use g++ instead of gcc

@hexdae hexdae mentioned this pull request Nov 17, 2023
copts = [
"-mcpu=cortex-m4",
"-mthumb",
"-mfloat-abi=hard",
"-mfpu=fpv4-sp-d16",
],
gcc_tool = "g++",
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how g++ can be enabled

RyanDraves and others added 2 commits February 6, 2024 14:57
* [CC] no stdinc

* [CC] bazel include and library paths

* [BAZEL] test backward compat

* [BAZEL] restore workspace

* [CONFIG] restore behavior

* [CI] fix windows env

* [GCC] no canonical headers

* [BZLMOD] add platforms dep (#27)

* [BZLMOD] add platforms dep

* [CI] switch to nativelink

* add support for GCC 13.2.1

---------

Co-authored-by: d-asnaghi <[email protected]>
@hexdae hexdae marked this pull request as ready for review February 6, 2024 20:01
@hexdae
Copy link
Owner Author

hexdae commented Feb 6, 2024

@RyanDraves mind taking a look at this? If you're happy and it works with bzlmod, I'll merge

Copy link
Contributor

@RyanDraves RyanDraves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM. I built and flashed a sample target onto a microcontroller with this commit; works great!

I'm using bzlmod w/ Bazel 7.0.0

@hexdae hexdae merged commit 0a42ae5 into master Feb 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants