-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added scraper for veroniquecloutier.com #1411
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First off thanks for the contribution!
A few changes needed most of which are small improvements / ideas for optimization. Let me know what you think!
Optional: if you wanted to try adding ingredient_groups support for this site this recipe contains it. |
Thank you so much for reviewing my PR! I made the recommended changes and also added support for |
Looks great! One last thing that I forgot to mention last time, our test suite enforces a specific order of JSON keys in the test files for ease of review. There is a helper script built in that can handle reordering the keys into the correct order that can be run with
|
Thanks for the catch! I ran the script to reorder JSON keys in the test file. Really appreciate you taking the time to review my PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - thank you, @shinyumh
Resolves #1252
Added support for veroniquecloutier.com. Since this is a French recipe website, recipe schema is not available. Thus, I tried my best to identify patterns of where information is located. This is especially true for functions like
yields()
,ingredients()
, andinstructions()
. I also chose not to implementtotal_time()
since most of the recipes I looked at did not have this information.Please let me know if there are any suggestions/feedback to make this better! Thank you in advance.