Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added scraper for veroniquecloutier.com #1411

Merged
merged 5 commits into from
Dec 7, 2024
Merged

Conversation

shinyumh
Copy link
Contributor

Resolves #1252

Added support for veroniquecloutier.com. Since this is a French recipe website, recipe schema is not available. Thus, I tried my best to identify patterns of where information is located. This is especially true for functions like yields(), ingredients(), and instructions(). I also chose not to implement total_time() since most of the recipes I looked at did not have this information.

Please let me know if there are any suggestions/feedback to make this better! Thank you in advance.

Copy link
Collaborator

@jknndy jknndy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First off thanks for the contribution!
A few changes needed most of which are small improvements / ideas for optimization. Let me know what you think!

recipe_scrapers/__init__.py Outdated Show resolved Hide resolved
recipe_scrapers/veroniquecloutier.py Outdated Show resolved Hide resolved
recipe_scrapers/veroniquecloutier.py Outdated Show resolved Hide resolved
recipe_scrapers/veroniquecloutier.py Outdated Show resolved Hide resolved
recipe_scrapers/veroniquecloutier.py Outdated Show resolved Hide resolved
recipe_scrapers/veroniquecloutier.py Outdated Show resolved Hide resolved
recipe_scrapers/veroniquecloutier.py Outdated Show resolved Hide resolved
@jknndy
Copy link
Collaborator

jknndy commented Nov 29, 2024

Optional: if you wanted to try adding ingredient_groups support for this site this recipe contains it.

@jknndy jknndy requested a review from jayaddison November 30, 2024 00:27
@shinyumh
Copy link
Contributor Author

shinyumh commented Dec 1, 2024

Optional: if you wanted to try adding ingredient_groups support for this site this recipe contains it.

Thank you so much for reviewing my PR! I made the recommended changes and also added support for ingredient_groups() by implementing custom grouping logic. Let me know if there is anything else I should add/change!

@jknndy
Copy link
Collaborator

jknndy commented Dec 1, 2024

Looks great! One last thing that I forgot to mention last time, our test suite enforces a specific order of JSON keys in the test files for ease of review. There is a helper script built in that can handle reordering the keys into the correct order that can be run with

python .\scripts\reorder_json_keys.py

@shinyumh
Copy link
Contributor Author

shinyumh commented Dec 1, 2024

Thanks for the catch! I ran the script to reorder JSON keys in the test file. Really appreciate you taking the time to review my PR!

Copy link
Collaborator

@jayaddison jayaddison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thank you, @shinyumh

@hhursev hhursev merged commit f81f53a into hhursev:main Dec 7, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add scraper for veroniquecloutier.com
4 participants