run hhast-migrate --ref-to-inout

bin/hhast-inspect.hack

@@ -26,7 +26,7 @@ async function hhast_inspect_main_async(): Awaitable<noreturn> {
       break;
     }
     $parts = \explode('/', $root);
-    \array_pop(&$parts);
+    \array_pop(inout $parts);
     $root = \implode('/', $parts);
   }
 

bin/hhast-lint.hack

@@ -26,7 +26,7 @@ async function hhast_lint_main_async(): Awaitable<noreturn> {
       break;
     }
     $parts = \explode('/', $root);
-    \array_pop(&$parts);
+    \array_pop(inout $parts);
     $root = \implode('/', $parts);
   }
 

bin/hhast-migrate.hack

@@ -26,7 +26,7 @@ async function hhast_migrate_main_async(): Awaitable<noreturn> {
       break;
     }
     $parts = \explode('/', $root);
-    \array_pop(&$parts);
+    \array_pop(inout $parts);
     $root = \implode('/', $parts);
   }
 

src/Migrations/RefToInoutMigration.hack

@@ -227,7 +227,7 @@ final class RefToInoutMigration extends BaseMigration {
 
       // special cases
       'array_multisort' => $n ==>
-        C\count($n['args']) < 1 || C\count($n['args']) > 9
+        C\is_empty($n['args']) || C\count($n['args']) > 9
           ? $n['root']
           : (
               self::renameImpl($n, 'array_multisort'.C\count($n['args']))

src/__Private/execute_async.hack

@@ -22,7 +22,7 @@ async function execute_async(string ...$args): Awaitable<vec<string>> {
   $spec = [0 => ['pipe', 'r'], 1 => ['pipe', 'w'], 2 => ['pipe', 'w']];
   $pipes = [];
 
-  $proc = \proc_open($command, $spec, &$pipes);
+  $proc = \proc_open($command, $spec, inout $pipes);
   invariant($proc, "Failed to execute: %s", $command);
 
   list($stdin, $stdout, $stderr) = $pipes;

src/__Private/get_typechecker_errors.hack

@@ -45,7 +45,14 @@ function get_typechecker_errors(string $path): vec<TTypecheckerError> {
     \escapeshellarg($path),
   ];
   $output = \tempnam(\sys_get_temp_dir(), 'hhast-temp');
-  \exec(Str\join($command, ' ').' >/dev/null 2>'.\escapeshellarg($output));
+
+  $_stdout = null;
+  $_exit_code = null;
+  \exec(
+    Str\join($command, ' ').' >/dev/null 2>'.\escapeshellarg($output),
+    inout $_stdout,
+    inout $_exit_code,
+  );
   // Exit code is unstable, so not checking it
 
   $lines = \file_get_contents($output);

tests/TestLib/TemporaryProject.hack

@@ -37,7 +37,7 @@ final class TemporaryProject implements \IAsyncDisposable {
     $this->hhServer = \proc_open(
       'hh_server '.\escapeshellarg($path).' >/dev/null 2>/dev/null',
       [],
-      &$pipes,
+      inout $pipes,
     );
     \file_put_contents($path.'/test.php', \file_get_contents($source_path));
   }