Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHH-18767, HHH-18772 add BatchSize for use with findMultiple() #9164

Merged
merged 8 commits into from
Oct 26, 2024

Conversation

gavinking
Copy link
Member

@gavinking gavinking commented Oct 25, 2024

  1. Add BatchSize, a FindOption synonymous with MultiIdLoadAccess.withBatchSize().
  2. Make MultiIdEntityLoaderArrayParam respect explicit batch sizes.

[Please describe here what your change is about]


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-18767
https://hibernate.atlassian.net/browse/HHH-18772

keep ignoring the *implicit* upper limit from the Dialect

refactor a very long method which was extremely hard to understand

Signed-off-by: Gavin King <[email protected]>
@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Oct 25, 2024

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [61fa700, 875b99c, 6f64c1c, 32a9129, 670c6d9]

› This message was automatically generated.

@gavinking gavinking changed the title HHH-18767 add BatchSize for use with findMultiple() HHH-18767, HHH-18772 add BatchSize for use with findMultiple() Oct 26, 2024
@gavinking gavinking merged commit b44833b into hibernate:main Oct 26, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant