Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHH-19179 Remove LGPL-only contributions - Batch 1 #9802

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dreab8
Copy link
Member

@dreab8 dreab8 commented Feb 25, 2025

https://hibernate.atlassian.net/browse/HHH-19179

The PR addresses the following commits

  • 50c12d9 , it cotyains only a test that has been removed

  • 816c976 ,
    removed only the test.
    Of the initial commit remains only

if ( copyCache.containsValue( original ) ) {
	cached = original;
}

that int the course of time has been refactored into

if ( copyCache.containsValue( original ) ) {
	retrun original;
}
  • 328fa23 ,
    The main change consist in change of signature of the CascadingActionsnoCascade methods, these two method were deprecated and this PR removes them

  • 7c2a588 , removed only test, the implementation seems trivial and plus the code has undergone further changes now it become

if ( isMappedBy ) {
   ...
}
 else if ( oneToMany
				&& property.hasDirectAnnotationUsage( OnDelete.class )
				&& !property.hasDirectAnnotationUsage( JoinColumn.class )
				&& !property.hasDirectAnnotationUsage( JoinColumns.class )) {
			throw new AnnotationException( "Unidirectional '@OneToMany' association '"
					+ qualify( propertyHolder.getPath(), propertyName )
					+ "' is annotated '@OnDelete' and must explicitly specify a '@JoinColumn'" );
		}
}
  • 4615ae1 , the main chainge is the Dialetc#buildLimitHandler(String RowSelection ) refactored into getLimitHandler() and the fact that limit handlers became singletons. It seems the change is how most of us would have implemented it.

  • fb15ee5 , tha mian change is the removing the Cascade constructor and make all its methods static in order to avoid creation of multiple Cascade object.
    It seems the change is how most of us would have implemented it.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-19178

@sebersole
Copy link
Member

the main chainge is the Dialetc#buildLimitHandler(String RowSelection ) refactored into getLimitHandler() and the fact that limit handlers became singletons. It seems the change is how most of us would have implemented it

And as we discussed its just reorganizing existing code

@sebersole
Copy link
Member

sebersole commented Feb 25, 2025

tha mian change is the removing the Cascade constructor and make all its methods static in order to avoid creation of multiple Cascade object.
It seems the change is how most of us would have implemented it.

I think this is also another case where its moving around existing code as above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants