-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twitter Poller #10873
Twitter Poller #10873
Conversation
The code looks good, but I’m starting to see a common pattern here. We have this poller/worker, @rbennettcw is also working on a similar worker/poller (same watermark model), and we keep adding more workers with cut-and-paste code for bootstrapping, health checks, etc. Maybe it’s time to generalize workers triggered by a cron job scheduler... @rbennettcw has already started down this path. |
Where/what poller? I'm fine with generalizing but shouldn't block this PR considering that this is a blocker for MomBot which aims to ship by valentine's day. |
I made a poller for clanker tokens. Same concept, different application. We can look into how to generalize at some point, but considering the time constraint, that'll have to happen later. |
That's fine, just noting the pattern here |
packages/commonwealth/server/workers/twitterWorker/twitterWorker.ts
Outdated
Show resolved
Hide resolved
# Conflicts: # libs/schemas/src/events/events.schemas.ts
packages/commonwealth/server/workers/twitterWorker/twitterWorker.ts
Outdated
Show resolved
Hide resolved
packages/commonwealth/server/workers/twitterWorker/twitterWorker.ts
Outdated
Show resolved
Hide resolved
# Conflicts: # libs/core/src/integration/outbox.schema.ts # libs/schemas/src/events/events.schemas.ts # libs/schemas/src/events/index.ts
Link to Issue
Closes: #10835
Closes: #10836
Description of Changes
Test Plan
Deployment Plan
Other Considerations