Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter Poller #10873

Merged
merged 21 commits into from
Feb 12, 2025
Merged

Twitter Poller #10873

merged 21 commits into from
Feb 12, 2025

Conversation

timolegros
Copy link
Collaborator

@timolegros timolegros commented Feb 6, 2025

Link to Issue

Closes: #10835
Closes: #10836

Description of Changes

  • Adds (but doesn't turn on) generalized twitter mentions poller infra

Test Plan

Deployment Plan

Other Considerations

  • As of now this is untested. I can't access twitter (endless sign in loop for some rzn) so I don't have a throw away account to test with.

@timolegros timolegros marked this pull request as ready for review February 7, 2025 06:51
@timolegros timolegros requested review from Rotorsoft and rbennettcw and removed request for Rotorsoft February 7, 2025 06:51
@Rotorsoft
Copy link
Contributor

The code looks good, but I’m starting to see a common pattern here. We have this poller/worker, @rbennettcw is also working on a similar worker/poller (same watermark model), and we keep adding more workers with cut-and-paste code for bootstrapping, health checks, etc. Maybe it’s time to generalize workers triggered by a cron job scheduler... @rbennettcw has already started down this path.

@timolegros
Copy link
Collaborator Author

@rbennettcw is also working on a similar worker/poller (same watermark model)

Where/what poller?

I'm fine with generalizing but shouldn't block this PR considering that this is a blocker for MomBot which aims to ship by valentine's day.

@rbennettcw
Copy link
Contributor

I made a poller for clanker tokens. Same concept, different application. We can look into how to generalize at some point, but considering the time constraint, that'll have to happen later.

@Rotorsoft
Copy link
Contributor

I made a poller for clanker tokens. Same concept, different application. We can look into how to generalize at some point, but considering the time constraint, that'll have to happen later.

That's fine, just noting the pattern here

# Conflicts:
#	libs/core/src/integration/outbox.schema.ts
#	libs/schemas/src/events/events.schemas.ts
#	libs/schemas/src/events/index.ts
@timolegros timolegros merged commit bcc9731 into master Feb 12, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the MomBotMentioned event and emit it from the twitterPoller Twitter Poller
3 participants