Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added conditional logic to only show when contests data available #10901

Merged
merged 2 commits into from
Feb 11, 2025
Merged

added conditional logic to only show when contests data available #10901

merged 2 commits into from
Feb 11, 2025

Conversation

Israellund
Copy link
Collaborator

Link to Issue

Closes: #10875

Description of Changes

  • added conditional logic to only show when contests data available

"How We Fixed It"

Test Plan

  • go to Contests page in Admin Capabilities on a community that has no contests.
  • confirm you see "No active contest available" and "No previous contests available" in their respective tabs.
    Screenshot 2025-02-07 at 10 03 00 AM

masvelio
masvelio reviewed Feb 7, 2025
View reviewed changes
Copy link
Contributor

@masvelio masvelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not correct solution. isContestAvailable is passed down and if it is false, it displays EmptyContestsList.

With this solution, empty contest list is never displayed so it is not possible to get to the launch contest page

@masvelio
Copy link
Contributor

masvelio commented Feb 7, 2025

you should see this card when there is no contest

image

this is EmptyContestsList

@Israellund Israellund requested a review from masvelio February 10, 2025 15:21
@Israellund Israellund merged commit f2401c9 into master Feb 11, 2025
8 checks passed
@Israellund Israellund deleted the israel.10875.fix-active-previous-contest-tabs branch February 11, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masvelio masvelio masvelio approved these changes

@KaleemNeslit KaleemNeslit KaleemNeslit approved these changes

@burtonator burtonator Awaiting requested review from burtonator

@mzparacha mzparacha Awaiting requested review from mzparacha

@salman-neslit salman-neslit Awaiting requested review from salman-neslit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Active/Previous contest tabs in Admin Capabilities
3 participants
@Israellund @masvelio @KaleemNeslit