Add contest status check to rollover

[ianrowan]

Link to Issue

Closes: #10925

Description of Changes

• Adds respective checks for recurring and single contests for ended contests

Test Plan

• Ensure regular rollover works
• Attempt to call on an already rolledover contest and ensure no error and a false return value
  up tickets, breaking changes, etc -->

[rbennettcw]

It works, but the calling function still continues to attempt to get scores, which fails.

@Rotorsoft it looks like this needs to be wired up to the caller function, and also the preemptive ending logic needs to be revisited because it's currently doing an infinite loop of rollover attempts.

[Rotorsoft]

It works, but the calling function still continues to attempt to get scores, which fails.

@Rotorsoft it looks like this needs to be wired up to the caller function, and also the preemptive ending logic needs to be revisited because it's currently doing an infinite loop of rollover attempts.

Don't see why we need to change anything, this was just an internal change to the rollover logic. From the outside we continue to set the "ended" flag to one-off contests if this function doesn't throw

[rbennettcw]

It works, but the calling function still continues to attempt to get scores, which fails.
@Rotorsoft it looks like this needs to be wired up to the caller function, and also the preemptive ending logic needs to be revisited because it's currently doing an infinite loop of rollover attempts.

Don't see why we need to change anything, this was just an internal change to the rollover logic. From the outside we continue to set the "ended" flag to one-off contests if this function doesn't throw

What I'm seeing is an error where it fails to get scores, and thus fails to mark as ended, and an infinite loop of rollovers:

PerformContestRollovers: failed with errors: Error: getContestScore ERROR: No winners found for contest ID (0) on contest address: 0xEF58835C929B548B520F6af4182931f56f99Ba19, Error: getContestScore ERROR: No winners found for contest ID (0) on contest address: 0x5923ce97dEc83e0103E75Fa7f9d4B8e1F1b45255, Error: getContestScore ERROR: No winners found for contest ID (0) on contest address: 0x457782033B26465ECA444fFa8c9bC4Bf60e91cDf, Error: getContestScore ERROR: No winners found for contest ID (0) on contest address: 0x9C5062E20ca5dF66537B8F63B4beffd6e7761754, Error: getContestScore ERROR: No winners found for contest ID (0) on contest address: 0xD515E39B8aD43F161a6A8F54ef65178061639d7F, Error: getContestScore ERROR: No winners found for contest ID (0) on contest address: 0xA00ef430B0b61AD509668AD6CD66E99BFDDDF709, Error: getContestScore ERROR: No winners found for contest ID (0) on contest address: 0x86C9867c961e87a43Da371F775839cAe0fe9964a, Error: getContestScore ERROR: No winners found for contest ID (0) on contest address: 0xc8E5aeA1d0cf1ABC02a0183050aFA84eeE16C558, Error: getContestScore ERROR: No winners found for contest ID (0) on contest address: 0x59c130594724f6B4F1F62eAc25081167027F2974"

[ianrowan]

@ryanbennettvoid to be clear this isnt occuring at the helper level right? Just an adjustment need to the usage in the policy or something? ie can this be merged

[rbennettcw]

@ianrowan yeah this is good to merge