Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add price to GetTokens #9905

Merged
merged 19 commits into from
Nov 20, 2024
Merged

Add price to GetTokens #9905

merged 19 commits into from
Nov 20, 2024

Conversation

timolegros
Copy link
Collaborator

@timolegros timolegros commented Nov 14, 2024 •
edited
Loading

Link to Issue

Closes: #9816 #9694

Description of Changes

  • Added GetToken query
  • Adds latest price and old price (24hrs ago) for each token in the GetTokens + GetToken query
  • Displays pricing data for tokens listed in explore page
  • Pricing filters added for tokens

Test Plan

Deployment Plan

Other Considerations

@mzparacha mzparacha linked an issue Nov 18, 2024 that may be closed by this pull request
Implement Pricing logic in Token Cards and Filters in the Explore Page #9694
Closed
@timolegros timolegros marked this pull request as ready for review November 19, 2024 16:42
@mzparacha mzparacha requested a review from Israellund November 19, 2024 17:41
@mzparacha mzparacha mentioned this pull request Nov 19, 2024
Merged
@masvelio masvelio requested a review from mzparacha November 20, 2024 09:01
masvelio
masvelio reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@masvelio masvelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting this error on migration

image

When I adjusted it for testing purpose I started getting ZOD errors about wrong types in getTokens query. So can't really test it

masvelio
masvelio approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@masvelio masvelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codewise looks good but didnt do CA testing

@timolegros timolegros merged commit 1ddbd01 into master Nov 20, 2024
10 checks passed
@timolegros
Copy link
Collaborator Author

getting this error on migration
image

When I adjusted it for testing purpose I started getting ZOD errors about wrong types in getTokens query. So can't really test it

@masvelio most likely you need to reset your DB (pnpm db-all) as you had old tokens in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masvelio masvelio masvelio approved these changes

@Rotorsoft Rotorsoft Rotorsoft approved these changes

@Israellund Israellund Israellund approved these changes

@kurtisassad kurtisassad Awaiting requested review from kurtisassad

@mzparacha mzparacha Awaiting requested review from mzparacha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🟩 Add token stats to GetTokens Implement Pricing logic in Token Cards and Filters in the Explore Page
5 participants
@timolegros @masvelio @Rotorsoft @Israellund @mzparacha