Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ronin to wallet ids #9929

Closed
wants to merge 1 commit into from
Closed

Conversation

Rotorsoft
Copy link
Contributor

Link to Issue

Closes: #TODO

Description of Changes

  • Adds FIXME widget to TODO page.

"How We Fixed It"

Test Plan

  • Unit tested the FIXME() call.
  • CA (click around) tested on local and frack:
    • TODO page

Deployment Plan

Other Considerations

@github-actions github-actions bot marked this pull request as draft November 15, 2024 17:34
@masvelio
Copy link
Contributor

masvelio commented Jan 6, 2025

@Rotorsoft let's try to cleanup the PR list. I guess it might be closed? Or let's plan how to proceed

@Rotorsoft
Copy link
Contributor Author

@timolegros @Israellund @masvelio this is another small PR to prevent a bunch of zod output errors in one community... let me know if we want to merge or fix the data?

@timolegros
Copy link
Collaborator

@timolegros @Israellund @masvelio this is another small PR to prevent a bunch of zod output errors in one community... let me know if we want to merge or fix the data?

Let's not add the ronin wallet id but rather fix the data. We should only have Wallet ids that we actively support in the enum otherwise we risk further confusion/issues down the line.

@Rotorsoft
Copy link
Contributor Author

@timolegros @Israellund @masvelio this is another small PR to prevent a bunch of zod output errors in one community... let me know if we want to merge or fix the data?

Let's not add the ronin wallet id but rather fix the data. We should only have Wallet ids that we actively support in the enum otherwise we risk further confusion/issues down the line.

ok, so closing this PR:

@Israellund can you follow up on the data fix?

select community_id, count(*) from "Addresses" where wallet_id = 'ronin' group by 1 order by 1;

axie-infinity | 887
testdao | 1
teste-only | 1

@Rotorsoft Rotorsoft closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants