-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Workflow optimisations #1239
ci: Workflow optimisations #1239
Conversation
… and develop matrix Signed-off-by: gsstoykov <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: gsstoykov <[email protected]>
@rbarkerSL Currently |
Signed-off-by: gsstoykov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Can you try to modify some source file in order to check how the codecov behaves with this change? We can revert the change in a next commit.
Signed-off-by: gsstoykov <[email protected]>
@andrewb1269hg could you give me some insight here if Roger is not available - #1239 (comment) |
Once this PR merges to the mainline it will use the tests you've implemented, rather than the tests that currently exist. I think we will need to override approval your PR to get it into the mainline, once others have reviewed it and there are no conflicts. @rbarker-dev and I will discuss. |
Signed-off-by: gsstoykov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
Introduces:
go vet
step asgolangci
handles that. (~[-20] seconds of overall CI run time)local-node
(~[-2] minutes of overall CI run time)Related issue(s):
Fixes #1207
Checklist