Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Workflow optimisations #1239

Merged
merged 18 commits into from
Mar 4, 2025

Conversation

gsstoykov
Copy link
Contributor

@gsstoykov gsstoykov commented Jan 30, 2025

Description:
Introduces:

  • Removed go vet step as golangci handles that. (~[-20] seconds of overall CI run time)
  • Added parallel runs for e2e/unit tests. Unit tests do not start up the local-node (~[-2] minutes of overall CI run time)
  • Removed old references to develop branch
  • Removed jobs for testnet/mainnet/previewnet which were not working

Related issue(s):

Fixes #1207

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@gsstoykov gsstoykov self-assigned this Jan 30, 2025
@gsstoykov gsstoykov linked an issue Jan 30, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

see 3 files with indirect coverage changes

@gsstoykov gsstoykov marked this pull request as ready for review February 3, 2025 12:09
@gsstoykov gsstoykov requested review from a team as code owners February 3, 2025 12:09
@gsstoykov
Copy link
Contributor Author

@rbarkerSL Currently Unit and Integration Tests Expected — Waiting for status to be reported stays as required although having the same named step in our flow. Could the required tag be removed or is there a way to configure the Unit and Integration Tests to be the ones i changed to.

Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you try to modify some source file in order to check how the codecov behaves with this change? We can revert the change in a next commit.

Signed-off-by: gsstoykov <[email protected]>
andrewb1269hg
andrewb1269hg previously approved these changes Feb 6, 2025
@gsstoykov
Copy link
Contributor Author

@andrewb1269hg could you give me some insight here if Roger is not available - #1239 (comment)

@andrewb1269hg
Copy link
Contributor

@andrewb1269hg could you give me some insight here if Roger is not available - #1239 (comment)

Once this PR merges to the mainline it will use the tests you've implemented, rather than the tests that currently exist.

I think we will need to override approval your PR to get it into the mainline, once others have reviewed it and there are no conflicts.

@rbarker-dev and I will discuss.

Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewb1269hg andrewb1269hg reopened this Mar 4, 2025
@gsstoykov gsstoykov merged commit dfb000c into main Mar 4, 2025
17 checks passed
@gsstoykov gsstoykov deleted the 1207-optimise-ci-and-remove-redundant-operations branch March 4, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimise CI and remove redundant operations
3 participants