-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated vendored libraries #277
Conversation
Hi Jordão, thank you for the PR. There is a problem with catch2, they switched from a single file header only model in v2 to a multi-header statically compiled library in v3. So moving to v3 requires a lot of changes, if you are ready to make them you are of course welcome, but it is also possible to stick to v2 for now :) No problem for increasing version number, once this is merged |
Thanks for the heads up @PerretB , rolled back |
Just a heads up, I updated the CI of the three latest versions of Python |
It seems that setuptools is being removed from default packages in 3.12 distributions. I think adding it there Line 44 in 53e03e1
|
Hey @PerretB, thanks for the feedback. |
ok indeed it's linked to this issue in xtensor xtensor-stack/xtensor#2736 , already reported as compiler bug in MSVC https://developercommunity.visualstudio.com/t/lambda-fails-to-implicitly-capture-constexpr-value/610504 |
I'm running out of ideas, I don't understand how xtensor tests are passing on MVSV :/ |
This reverts commit 95e6fa2.
@JoOkuma I will try to replicate the problem locally and see if I can find a fix |
@JoOkuma ok it's fixed. Do you mind creating a new clean PR with only required changes in small commits? Otherwise I'll do it during the week |
replaced by #278 |
Hi @PerretB , I updated the libraries, this should close #276
It's passing on my environment with
numpy==2.0.0
.If this gets merged, could we bump a version?
Note that I also removed an unused line in
include/higra/image/graph_image.hpp
to silence a warning.