Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(diagrams): [activity] Should draw a no-action-line when there is no else block #259

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

hikerpig
Copy link
Owner

@hikerpig hikerpig commented Feb 25, 2024

Related #249

Copy link

vercel bot commented Feb 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pintorajs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2024 7:39am

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 91.68%. Comparing base (87f80b1) to head (01a5aea).
Report is 129 commits behind head on master.

❗ Current head 01a5aea differs from pull request most recent head befc29d. Consider uploading reports for the commit befc29d to get more accurate results

Files Patch % Lines
packages/pintora-diagrams/src/activity/artist.ts 64.70% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   91.06%   91.68%   +0.62%     
==========================================
  Files          69       88      +19     
  Lines        3994     5148    +1154     
  Branches      762      914     +152     
==========================================
+ Hits         3637     4720    +1083     
- Misses        357      428      +71     
Flag Coverage Δ
unittests 91.68% <64.70%> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hikerpig hikerpig force-pushed the feat-activity-no-action-line branch from 01a5aea to befc29d Compare February 25, 2024 07:36
@hikerpig hikerpig merged commit 3457b22 into master Feb 25, 2024
4 of 7 checks passed
@hikerpig hikerpig deleted the feat-activity-no-action-line branch February 25, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant