Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add option renderInSubprocess to avoid polluting global scope #276

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

hikerpig
Copy link
Owner

@hikerpig hikerpig commented Apr 1, 2024

In order to avoid polluting the global environment, cli render function wil by default fork a subprocess to run the actual rendering.

Copy link

vercel bot commented Apr 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pintorajs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2024 3:47pm

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 82.40000% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 91.53%. Comparing base (87f80b1) to head (911062f).
Report is 148 commits behind head on master.

Files Patch % Lines
...ackages/pintora-cli/src/subprocess-render/index.ts 15.78% 16 Missing ⚠️
packages/pintora-cli/src/render-impl.ts 94.56% 5 Missing ⚠️
packages/pintora-cli/src/render.ts 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
+ Coverage   91.06%   91.53%   +0.47%     
==========================================
  Files          69       91      +22     
  Lines        3994     5200    +1206     
  Branches      762      918     +156     
==========================================
+ Hits         3637     4760    +1123     
- Misses        357      440      +83     
Flag Coverage Δ
unittests 91.53% <82.40%> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hikerpig hikerpig merged commit 4c8346b into master Apr 9, 2024
11 of 12 checks passed
@hikerpig hikerpig deleted the fix-cli-polution-vm branch April 9, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant