Skip to content

Commit

Permalink
fix invalid perfects indicator* *for 99% of songs
Browse files Browse the repository at this point in the history 
idk why green grass still does it bruh
  • Loading branch information
@jnackmclain
jnackmclain committed Jan 28, 2025
1 parent 999602d commit 496cb6e
Showing 1 changed file with 19 additions and 7 deletions.
26 changes: 19 additions & 7 deletions _ark/dx/track/countdown/dx_countdown_midi_parsers.dta
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
(up FALSE)
(append_length TRUE)
(compress TRUE)
;(message_type midi_parser)
(message_type midi_parser)
(mp.up FALSE)
(idle)
(allowed_notes
Expand All @@ -17,6 +17,7 @@
{set $first_guitar_gem_tracked TRUE}
{set $tracked_break_num_guitar 0}
{set $first_guitar_gem_beat {int $mp.start}}
{set $mp.endcache 0} ; cache note end time
{if {> $first_guitar_gem_beat 16}
{push_back $guitar_note_tracker ("delay_0" 0 $first_guitar_gem_beat)}
{set $guitar_note_tracker {array $guitar_note_tracker}}
Expand All @@ -34,9 +35,10 @@
{if {> $dx_final_note_guitar $dx_final_note} {set $dx_final_note $dx_final_note_guitar}}
{if $dx_perfects_indicator
{if {|| {== $mp.val 96} {== $mp.val 97} {== $mp.val 98} {== $mp.val 99} {== $mp.val 100}}
{if {>= $mp.prev_start 0.03}
{if {>= {- $mp.start $mp.endcache} 0}
{push_back $guitar_note_tracker_2 {* {beat_to_seconds $mp.start} 1000}}
{set $guitar_note_tracker_2_size {size $guitar_note_tracker_2}}
{set $mp.endcache $mp.end} ; cache note end time
}
}
}
Expand Down Expand Up @@ -98,6 +100,7 @@
{unless $first_real_guitar_gem_tracked
{set $first_real_guitar_gem_tracked TRUE}
{set $tracked_break_num_real_guitar 0}
{set $mp.endcache 0} ; cache note end time
{set $first_real_guitar_gem_beat {int $mp.start}}
{if {> $first_real_guitar_gem_beat 16}
{push_back $real_guitar_note_tracker ("delay_0" 0 $first_real_guitar_gem_beat)}
Expand All @@ -116,9 +119,10 @@
{if {> $dx_final_note_real_guitar $dx_final_note} {set $dx_final_note $dx_final_note_real_guitar}}
{if $dx_perfects_indicator
{if {|| {== $mp.val 96} {== $mp.val 97} {== $mp.val 98} {== $mp.val 99} {== $mp.val 100} {== $mp.val 101}}
{if {>= $mp.prev_start 0.03}
{if {>= {- $mp.start $mp.endcache} 0}
{push_back $real_guitar_note_tracker_2 {* {beat_to_seconds $mp.start} 1000}}
{set $real_guitar_note_tracker_2_size {size $real_guitar_note_tracker_2}}
{set $mp.endcache $mp.end} ; cache note end time
}
}
}
Expand Down Expand Up @@ -293,6 +297,7 @@
{unless $first_bass_gem_tracked
{set $first_bass_gem_tracked TRUE}
{set $tracked_break_num_bass 0}
{set $mp.endcache 0} ; cache note end time
{set $first_bass_gem_beat {int $mp.start}}
{if {> $first_bass_gem_beat 16}
{push_back $bass_note_tracker ("delay_0" 0 $first_bass_gem_beat)}
Expand All @@ -311,9 +316,10 @@
{if {> $dx_final_note_bass $dx_final_note} {set $dx_final_note $dx_final_note_bass}}
{if $dx_perfects_indicator
{if {|| {== $mp.val 96} {== $mp.val 97} {== $mp.val 98} {== $mp.val 99} {== $mp.val 100}}
{if {>= $mp.prev_start 0.03}
{if {>= {- $mp.start $mp.endcache} 0}
{push_back $bass_note_tracker_2 {* {beat_to_seconds $mp.start} 1000}}
{set $bass_note_tracker_2_size {size $bass_note_tracker_2}}
{set $mp.endcache $mp.end} ; cache note end time
}
}
}
Expand Down Expand Up @@ -375,6 +381,7 @@
{unless $first_real_bass_gem_tracked
{set $first_real_bass_gem_tracked TRUE}
{set $tracked_break_num_real_bass 0}
{set $mp.endcache 0} ; cache note end time
{set $first_real_bass_gem_beat {int $mp.start}}
{if {> $first_real_bass_gem_beat 16}
{push_back $real_bass_note_tracker ("delay_0" 0 $first_real_bass_gem_beat)}
Expand All @@ -393,9 +400,10 @@
{if {> $dx_final_note_real_bass $dx_final_note} {set $dx_final_note $dx_final_note_real_bass}}
{if $dx_perfects_indicator
{if {|| {== $mp.val 96} {== $mp.val 97} {== $mp.val 98} {== $mp.val 99} {== $mp.val 100} {== $mp.val 101}}
{if {>= $mp.prev_start 0.03}
{if {>= {- $mp.start $mp.endcache} 0}
{push_back $real_bass_note_tracker_2 {* {beat_to_seconds $mp.start} 1000}}
{set $real_bass_note_tracker_2_size {size $real_bass_note_tracker_2}}
{set $mp.endcache $mp.end} ; cache note end time
}
}
}
Expand Down Expand Up @@ -458,6 +466,7 @@
{unless $first_keys_gem_tracked
{set $first_keys_gem_tracked TRUE}
{set $tracked_break_num_keys 0}
{set $mp.endcache 0} ; cache note end time
{set $first_keys_gem_beat {int $mp.start}}
{if {> $first_keys_gem_beat 16}
{push_back $keys_note_tracker ("delay_0" 0 $first_keys_gem_beat)}
Expand All @@ -476,9 +485,10 @@
{if {> $dx_final_note_keys $dx_final_note} {set $dx_final_note $dx_final_note_keys}}
{if $dx_perfects_indicator
{if {|| {== $mp.val 96} {== $mp.val 97} {== $mp.val 98} {== $mp.val 99} {== $mp.val 100}}
{if {>= $mp.prev_start 0.03}
{if {>= {- $mp.start $mp.endcache} 0}
{push_back $keys_note_tracker_2 {* {beat_to_seconds $mp.start} 1000}}
{set $keys_note_tracker_2_size {size $keys_note_tracker_2}}
{set $mp.endcache $mp.end} ; cache note end time
}
}
}
Expand Down Expand Up @@ -541,6 +551,7 @@
{unless $first_real_keys_gem_tracked
{set $first_real_keys_gem_tracked TRUE}
{set $tracked_break_num_real_keys 0}
{set $mp.endcache 0} ; cache note end time
{set $first_real_keys_gem_beat {int $mp.start}}
{if {> $first_real_keys_gem_beat 16}
{push_back $real_keys_note_tracker ("delay_0" 0 $first_real_keys_gem_beat)}
Expand All @@ -559,9 +570,10 @@
{if {> $dx_final_note_real_keys $dx_final_note} {set $dx_final_note $dx_final_note_real_keys}}
{if $dx_perfects_indicator
{if {&& {!= $mp.val 115} {!= $mp.val 116}}
{if {>= $mp.prev_start 0.03}
{if {>= {- $mp.start $mp.endcache} 0}
{push_back $real_keys_note_tracker_2 {* {beat_to_seconds $mp.start} 1000}}
{set $real_keys_note_tracker_2_size {size $real_keys_note_tracker_2}}
{set $mp.endcache $mp.end} ; cache note end time
}
}
}
Expand Down

0 comments on commit 496cb6e

Please sign in to comment.