Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portuguese translation update and folder restructure #1022

Merged
merged 3 commits into from
Feb 9, 2025

Conversation

ruggeryiury
Copy link

No description provided.

@jnackmclain
Copy link
Member

I do not understand why this pr removed the usage of user sources and user locale updates

@ruggeryiury
Copy link
Author

ruggeryiury commented Feb 9, 2025

it didn't, the user defined locales are still called on the main dx_locale_updates.dta, to be applied on both languages. On the last commit, the user defines locales were called twice, inside the RB3DX_PTBR conditional and later again globally, applying on both languages, I just removed inside the RB3DX_PTBR conditional.

@jnackmclain
Copy link
Member

the diff shows them removed but maybe bad git diff moment?
image

@ruggeryiury
Copy link
Author

image

Oh, I found it, I placed them on _ark/ui/locale/eng/locale_updates_keep.dta, outside any conditional to apply on both languages directly.

@jnackmclain
Copy link
Member

oh okay, make sure that line is also in esl as well and should be good
as long as the actual location or contents of the user dtas has not changed, this should be fine

@jnackmclain jnackmclain merged commit 80a8774 into hmxmilohax:develop Feb 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants