Add defaultPoint option #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the default point on load was assumed to be 0. This sets that as the default, but allows it to be overridden in the options so that points other than point 0 may be allowed as the default.
The previous commit made assumptions on refresh that transition delay would/should be 0. This has been fixed.
Tests along the pattern of maxPoint, that when defaultPoint is set, the correct values should be reflected by currentPoint
Add defaultPoint feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option (and related tests) to allow for the specification of a default point to be used at initialization. Default behavior is to work as before.
An example use case might be a calendar that allows swiping to scan months forward and back, but with a limited range of selectable dates. This would allow for starting in the current month instead of the earliest month. Also useful for image sliders that might want to start on a random slide, or for mobile where a user could swipe left or right on content to view different options.