Refactor Clipsal CBus support #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Working refactored CBus support in MisterHouse.
Include notice to inform users that CBus support has moved to Clipsal_CBus.pm
Add comments to the code, and also reorder the if statements to be in order of the CBus message code.
Plus some trivial description updates and removing a superfluous debug statement.
It was assumed ramping either ON or OFF. This permits a ramp somewhere in between.
|
Hello Jon, thank you for the pull request. You code is stand-alone and does not interfere with other code, so OK for met to merge into master! Best regards, |
tobser
pushed a commit
to tobser/misterhouse
that referenced
this pull request
Apr 27, 2016
Refactor Clipsal CBus support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial refactor of the Clipsal CBus support, which has previously been provided by cbus.pl. It does not break the function of cbus.pl, but does include a notice to users of that code.
This refactor makes cbus support more MisterHouse native. For example, CBus objects are now defined in an "mht" file, and CBus group objects include a set() method that is used by IA7, such that the web UI now synchronises properly with CBus.