Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add self-hosted runner and manual execution of performance tests #88

Merged
merged 22 commits into from
Sep 17, 2024
Merged

Add self-hosted runner and manual execution of performance tests #88

merged 22 commits into from
Sep 17, 2024

Conversation

cdunster
Copy link
Contributor

@cdunster cdunster commented Sep 6, 2024

Closes #5.

@cdunster cdunster self-assigned this Sep 6, 2024
@cdunster cdunster linked an issue Sep 6, 2024 that may be closed by this pull request
Wind Tunnel scenario execution #5
Closed
5 tasks
@cdunster cdunster changed the title Add self-hosted runner and manual execution of performance tests (#5) Add self-hosted runner and manual execution of performance tests Sep 6, 2024
@cdunster cdunster force-pushed the 5-wind-tunnel-scenario-execution branch from e186d5d to 5d0594f Compare September 9, 2024 11:24
@cdunster cdunster force-pushed the 5-wind-tunnel-scenario-execution branch 12 times, most recently from f4341a1 to b33e0ab Compare September 13, 2024 12:03
@cdunster cdunster force-pushed the 5-wind-tunnel-scenario-execution branch from a5ec512 to 5f376c0 Compare September 13, 2024 15:03
@cdunster
Copy link
Contributor Author

cdunster commented Sep 13, 2024 •
edited
Loading

As this workflow can only be triggered manually then it cannot be run until it is on the default branch. Therefore I tested it by triggering on this PR instead, the results of what it looks like can be found here.

@cdunster cdunster marked this pull request as ready for review September 13, 2024 15:08
ThetaSinner
ThetaSinner previously approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@ThetaSinner ThetaSinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I have a few minor comments and two that I think are worth a look. One about overlapping minimal/large for app install and one about fetching telegraf from nixpkgs

.github/workflows/performance.yaml Outdated Show resolved Hide resolved
.github/workflows/performance.yaml Show resolved Hide resolved
.github/workflows/performance.yaml Show resolved Hide resolved
.github/workflows/performance.yaml Outdated Show resolved Hide resolved
.github/workflows/performance.yaml Show resolved Hide resolved
.github/workflows/performance.yaml Outdated Show resolved Hide resolved
.github/workflows/performance.yaml Show resolved Hide resolved
.github/workflows/performance.yaml Outdated Show resolved Hide resolved
.github/workflows/performance.yaml Show resolved Hide resolved
cdunster and others added 2 commits September 16, 2024 15:35
@cdunster @ThetaSinner
refactor(ci): rename steps that run the scenarios
899b26b 
Co-authored-by: ThetaSinner <[email protected]>
@cdunster
chore(ci): add script to flake to call telegraf as expected in the CI
acfee97 
This is so that we use the telegraf version from the lockfile.
ThetaSinner
ThetaSinner previously approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@ThetaSinner ThetaSinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super!

@cdunster
chore(ci): split the app_install scenario in two
7411581 
This tests installing the minimally-small and large hApps separately.
@cdunster cdunster force-pushed the 5-wind-tunnel-scenario-execution branch 2 times, most recently from 05b5cce to 7411581 Compare September 16, 2024 17:19
@cdunster cdunster enabled auto-merge (squash) September 16, 2024 17:23
@cdunster cdunster merged commit aadc606 into main Sep 17, 2024
2 checks passed
@cdunster cdunster deleted the 5-wind-tunnel-scenario-execution branch September 17, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThetaSinner ThetaSinner ThetaSinner approved these changes

Assignees

@cdunster cdunster

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wind Tunnel scenario execution
2 participants
@cdunster @ThetaSinner