Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve countersigning scenario #89

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Improve countersigning scenario #89

merged 4 commits into from
Oct 10, 2024

Conversation

ThetaSinner
Copy link
Member

@ThetaSinner ThetaSinner commented Sep 6, 2024 •
edited
Loading

image

@ThetaSinner ThetaSinner self-assigned this Sep 6, 2024
ThetaSinner
ThetaSinner commented Sep 6, 2024
View reviewed changes
flake.nix Outdated Show resolved Hide resolved
@ThetaSinner
Copy link
Member Author

ThetaSinner commented Sep 16, 2024 •
edited
Loading

  • Add missing reset call to this scenario

@ThetaSinner ThetaSinner force-pushed the improve-countersigning-test branch from ef9aaad to c5447f3 Compare September 30, 2024 11:29
@ThetaSinner ThetaSinner force-pushed the improve-countersigning-test branch from 8a0dd4f to 0457d6d Compare September 30, 2024 15:17
@ThetaSinner ThetaSinner requested a review from a team September 30, 2024 16:36
neonphog
neonphog previously approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@neonphog neonphog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm : )

cdunster
cdunster reviewed Oct 1, 2024
View reviewed changes
conductor-config-ci.yaml Show resolved Hide resolved
conductor-config.yaml Show resolved Hide resolved
scenarios/two_party_countersigning/src/main.rs Outdated Show resolved Hide resolved
scenarios/two_party_countersigning/src/main.rs Outdated Show resolved Hide resolved
scenarios/two_party_countersigning/Cargo.toml Outdated Show resolved Hide resolved
@ThetaSinner ThetaSinner added this pull request to the merge queue Oct 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 10, 2024
@ThetaSinner ThetaSinner added this pull request to the merge queue Oct 10, 2024
Merged via the queue into main with commit 0c56b4d Oct 10, 2024
2 checks passed
@ThetaSinner ThetaSinner deleted the improve-countersigning-test branch October 10, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jost-s jost-s jost-s left review comments

@cdunster cdunster cdunster left review comments

@neonphog neonphog neonphog approved these changes

Assignees

@ThetaSinner ThetaSinner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ThetaSinner @neonphog @cdunster @jost-s