Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cuda and cuda-with-dask support for inspection reductions #1219

Merged
merged 6 commits into from
May 24, 2023
Merged

Cuda and cuda-with-dask support for inspection reductions #1219

merged 6 commits into from
May 24, 2023

Conversation

ianthomas23
Copy link
Member

This implements CUDA and CUDA-with-Dask support for the inspection reductions first, first_n, last and last_n, as well as the same reductions wrapped in a where reduction e.g. where(first_n("value", n=3), "other").

Closes #1182 and #1207.

This is implemented on top of #1217; ideally that would be merged before this to keep the commits separate.

@ianthomas23 ianthomas23 added this to the v0.14.5 milestone May 19, 2023
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #1219 (3470fba) into main (fc82f8e) will decrease coverage by 1.03%.
The diff coverage is 34.92%.

@@            Coverage Diff             @@
##             main    #1219      +/-   ##
==========================================
- Coverage   84.63%   83.61%   -1.03%     
==========================================
  Files          35       35              
  Lines        8600     8734     +134     
==========================================
+ Hits         7279     7303      +24     
- Misses       1321     1431     +110     
Impacted Files Coverage Δ
datashader/utils.py 81.53% <ø> (-0.33%) ⬇️
datashader/transfer_functions/_cuda_utils.py 20.63% <13.95%> (-1.97%) ⬇️
datashader/reductions.py 79.24% <36.76%> (-4.37%) ⬇️
datashader/compiler.py 88.35% <100.00%> (+0.44%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ianthomas23 ianthomas23 merged commit 25fbc3c into holoviz:main May 24, 2023
@ianthomas23 ianthomas23 deleted the cuda_first_where_etc branch May 24, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dask and CUDA support for first and last reductions
1 participant