Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(users): edit profile username not lowercase #2279

Merged
merged 2 commits into from
Feb 9, 2025

Conversation

Meierschlumpf
Copy link
Member


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

Closes #2219

@Meierschlumpf Meierschlumpf added the bug Something isn't working label Feb 8, 2025
@Meierschlumpf Meierschlumpf self-assigned this Feb 8, 2025
@Meierschlumpf Meierschlumpf requested a review from a team as a code owner February 8, 2025 23:16
Copy link

deepsource-io bot commented Feb 8, 2025

Here's the code health analysis summary for commits 42a6814..ef66b54. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Feb 8, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 21.56% 8692 / 40314
🔵 Statements 21.56% 8692 / 40314
🔵 Functions 26.8% 341 / 1272
🔵 Branches 62.45% 993 / 1590
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/api/src/router/user.ts 46.84% 63.63% 100% 46.84% 85-92, 110-145, 153-161, 169-176, 189-202, 225-256, 265-269, 277-281, 284-288, 309-313, 322-381, 388-425, 444-447, 454, 461-466, 472-484, 492-518, 550-554
packages/validation/src/user.ts 100% 100% 100% 100%
Generated in workflow #5000 for commit ef66b54 by the Vitest Coverage Report Action

@Meierschlumpf Meierschlumpf merged commit b7fd247 into dev Feb 9, 2025
13 checks passed
@Meierschlumpf Meierschlumpf deleted the fix-edit-profile-username-casing branch February 9, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: It is possible to change the name the username of an account and it makes impossible to login
2 participants