Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI and Linter #50

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Update CI and Linter #50

merged 2 commits into from
Feb 22, 2024

Conversation

bgoncal
Copy link
Member

@bgoncal bgoncal commented Feb 21, 2024

No description provided.

@bgoncal bgoncal requested a review from zacwest February 21, 2024 09:46
@bgoncal bgoncal self-assigned this Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1f0202a) 99.93% compared to head (d2e2f0f) 99.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files          46       46           
  Lines        1470     1471    +1     
=======================================
+ Hits         1469     1470    +1     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zacwest zacwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<100% :'( I'm not sure you can resolve this one, but I'd love to try to keep the weird 100% coverage that I was able to get to. Maybe on iOS 17, ! the result, since we know it cannot fail now?

@bgoncal bgoncal force-pushed the update-ci-and-linter branch from 709cf26 to d2e2f0f Compare February 22, 2024 09:56
@bgoncal bgoncal merged commit 7ba1207 into main Feb 22, 2024
5 checks passed
@bgoncal bgoncal deleted the update-ci-and-linter branch February 22, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants