Use icon translations for enphase_envoy.

home-assistant · Jan 21, 2025 · 9ab4be3 · 9ab4be3
1 parent dd31c2c
commit 9ab4be3
Show file tree

Hide file tree

Showing 9 changed files with 532 additions and 944 deletions.
diff --git a/homeassistant/components/enphase_envoy/binary_sensor.py b/homeassistant/components/enphase_envoy/binary_sensor.py
@@ -67,7 +67,6 @@ class EnvoyEnpowerBinarySensorEntityDescription(BinarySensorEntityDescription):
     EnvoyEnpowerBinarySensorEntityDescription(
         key="mains_oper_state",
         translation_key="grid_status",
-        icon="mdi:transmission-tower",
         value_fn=lambda enpower: enpower.mains_oper_state == "closed",
     ),
 )

diff --git a/homeassistant/components/enphase_envoy/icons.json b/homeassistant/components/enphase_envoy/icons.json
@@ -0,0 +1,58 @@
+{
+  "entity": {
+    "binary_sensor": {
+      "grid_status": {
+        "default": "mdi:transmission-tower",
+        "state": {
+          "off": "mdi:transmission-tower-off"
+        }
+      }
+    },
+    "sensor": {
+      "current_power_production": {
+        "default": "mdi:solar-power"
+      },
+      "daily_production": {
+        "default": "mdi:solar-power"
+      },
+      "seven_days_production": {
+        "default": "mdi:solar-power"
+      },
+      "lifetime_production": {
+        "default": "mdi:solar-power"
+      },
+      "current_power_production_phase": {
+        "default": "mdi:solar-power"
+      },
+      "daily_production_phase": {
+        "default": "mdi:solar-power"
+      },
+      "seven_days_production_phase": {
+        "default": "mdi:solar-power"
+      },
+      "lifetime_production_phase": {
+        "default": "mdi:solar-power"
+      },
+      "max_capacity": {
+        "default": "mdi:battery-charging-100"
+      },
+      "available_energy": {
+        "default": "mdi:battery-50"
+      }
+    },
+    "switch": {
+      "grid_enabled": {
+        "default": "mdi:transmission-tower",
+        "state": {
+          "off": "mdi:transmission-tower-off"
+        }
+      },
+      "relay_status": {
+        "default": "mdi:electric-switch-closed",
+        "state": {
+          "off": "mdi:electric-switch"
+        }
+      }
+    }
+  }
+}
diff --git a/homeassistant/components/enphase_envoy/quality_scale.yaml b/homeassistant/components/enphase_envoy/quality_scale.yaml
@@ -81,7 +81,7 @@ rules:
   entity-disabled-by-default: done
   entity-translations: done
   exception-translations: done
-  icon-translations: todo
+  icon-translations: done
   reconfiguration-flow: done
   repair-issues:
     status: exempt

diff --git a/homeassistant/components/enphase_envoy/sensor.py b/homeassistant/components/enphase_envoy/sensor.py
@@ -55,7 +55,6 @@
 from .coordinator import EnphaseConfigEntry, EnphaseUpdateCoordinator
 from .entity import EnvoyBaseEntity
 
-ICON = "mdi:flash"
 _LOGGER = logging.getLogger(__name__)
 
 INVERTERS_KEY = "inverters"
@@ -946,8 +945,6 @@ class EnvoySensorBaseEntity(EnvoyBaseEntity, SensorEntity):
 class EnvoySystemSensorEntity(EnvoySensorBaseEntity):
     """Envoy system base entity."""
 
-    _attr_icon = ICON
-
     def __init__(
         self,
         coordinator: EnphaseUpdateCoordinator,
@@ -1174,7 +1171,6 @@ def native_value(
 class EnvoyInverterEntity(EnvoySensorBaseEntity):
     """Envoy inverter entity."""
 
-    _attr_icon = ICON
     entity_description: EnvoyInverterSensorEntityDescription
 
     def __init__(

diff --git a/homeassistant/components/enphase_envoy/switch.py b/homeassistant/components/enphase_envoy/switch.py
@@ -60,6 +60,7 @@ class EnvoyStorageSettingsSwitchEntityDescription(SwitchEntityDescription):
 
 RELAY_STATE_SWITCH = EnvoyDryContactSwitchEntityDescription(
     key="relay_status",
+    translation_key="relay_status",
     value_fn=lambda dry_contact: dry_contact.status == DryContactStatus.CLOSED,
     turn_on_fn=lambda envoy, id: envoy.close_dry_contact(id),
     turn_off_fn=lambda envoy, id: envoy.open_dry_contact(id),

diff --git a/tests/components/enphase_envoy/snapshots/test_binary_sensor.ambr b/tests/components/enphase_envoy/snapshots/test_binary_sensor.ambr
@@ -255,7 +255,7 @@
     'options': dict({
     }),
     'original_device_class': None,
-    'original_icon': 'mdi:transmission-tower',
+    'original_icon': None,
     'original_name': 'Grid status',
     'platform': 'enphase_envoy',
     'previous_unique_id': None,
@@ -269,7 +269,6 @@
   StateSnapshot({
     'attributes': ReadOnlyDict({
       'friendly_name': 'Enpower 654321 Grid status',
-      'icon': 'mdi:transmission-tower',
     }),
     'context': <ANY>,
     'entity_id': 'binary_sensor.enpower_654321_grid_status',