Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Weatherflow Cloud wind support via websocket #125611

Open
wants to merge 49 commits into
base: dev
Choose a base branch
from

Conversation

jeeftor
Copy link
Contributor

@jeeftor jeeftor commented Sep 9, 2024

Proposed change

Wind data is available via WebSockets via two different types of messages. There is a rapid_wind message that gives Speed/Direction and arrives at about a 3minute interval. There is also an obs_st message that gives averages over a time window.

image

Added extended attributes to explain data source whether its REST or WebSocket
image

  • Utilize web socket connection to back end server to pull wind speed & direction (ultimately more sensors may transition to WS over REST)

jeeftor/weatherflow4py@v1.0.6...v1.2.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@jeeftor jeeftor marked this pull request as ready for review September 9, 2024 19:10
homeassistant/components/weatherflow_cloud/const.py Outdated Show resolved Hide resolved
homeassistant/components/weatherflow_cloud/icons.json Outdated Show resolved Hide resolved
homeassistant/components/weatherflow_cloud/manifest.json Outdated Show resolved Hide resolved
homeassistant/components/weatherflow_cloud/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/weatherflow_cloud/sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft September 10, 2024 14:21
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@jeeftor jeeftor mentioned this pull request Sep 10, 2024
19 tasks
@home-assistant home-assistant bot requested a review from joostlek September 18, 2024 12:26
Copy link

github-actions bot commented Dec 6, 2024

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes.
Thank you for your contribution!

@github-actions github-actions bot added the stale label Dec 6, 2024
@jeeftor
Copy link
Contributor Author

jeeftor commented Dec 6, 2024

@joostlek - I think this is awaiting your review when you get around to it ... its gone stale :)

@github-actions github-actions bot removed the stale label Dec 6, 2024
@jeeftor jeeftor marked this pull request as draft December 18, 2024 13:48
@jeeftor jeeftor marked this pull request as ready for review December 18, 2024 13:48
@jeeftor jeeftor marked this pull request as draft December 30, 2024 15:01
@jeeftor jeeftor marked this pull request as ready for review December 30, 2024 15:01
homeassistant/components/weatherflow_cloud/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/weatherflow_cloud/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/weatherflow_cloud/coordinator.py Outdated Show resolved Hide resolved
homeassistant/components/weatherflow_cloud/entity.py Outdated Show resolved Hide resolved
homeassistant/components/weatherflow_cloud/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/weatherflow_cloud/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/weatherflow_cloud/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/weatherflow_cloud/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/weatherflow_cloud/sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft January 17, 2025 09:30
@jeeftor jeeftor marked this pull request as ready for review January 21, 2025 15:40
@home-assistant home-assistant bot requested a review from joostlek January 21, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants