-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update yolink "play on speaker hub" action to allow optional values (to match YoLink API) #133099
Conversation
Hey there @matrixd2, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
@joostlek do you mind taking another look please? Thank you! |
Hi @joostlek checking in on if you can review this again. Thank you! |
Proposed change
The
SpeakerHub.playAudio
accepts optional arguments for thetone
,repeat
, andvolume
parameters. But the HA service definition makes these arguments required. I've updated the service definition so that the arguments are optional.Note that the current logic also sets
repeat
to0
when it's unset by the user so I have preserved that logic.Type of change
Additional information
Checklist
ruff format homeassistant tests
)async_setup
in the test environment.If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: