-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add niko_home_control quality scale #134000
Open
VandeurenGlenn
wants to merge
3
commits into
home-assistant:dev
Choose a base branch
from
VandeurenGlenn:nhc-quality-scale
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add niko_home_control quality scale #134000
VandeurenGlenn
wants to merge
3
commits into
home-assistant:dev
from
VandeurenGlenn:nhc-quality-scale
+90
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VandeurenGlenn
force-pushed
the
nhc-quality-scale
branch
from
December 25, 2024 14:32
1064863
to
4bc59dd
Compare
MartinHjelmare
changed the title
code-quality(niko_home_control): Add quality scale
Add niko_home_control quality scale
Dec 25, 2024
VandeurenGlenn
force-pushed
the
nhc-quality-scale
branch
from
December 26, 2024 10:38
4bc59dd
to
cb2453f
Compare
joostlek
requested changes
Dec 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add the full YAML here and not just a subset of all the rules
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Well, hassfest didn't complain :p |
VandeurenGlenn
force-pushed
the
nhc-quality-scale
branch
from
January 18, 2025 23:14
0ac306b
to
4bf6764
Compare
VandeurenGlenn
force-pushed
the
nhc-quality-scale
branch
from
January 19, 2025 11:05
4bf6764
to
9977255
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add quality scale to niko_home_control
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: