Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sensors for HomeWizard Plug-In Battery #135418

Conversation

DCSBL
Copy link
Contributor

@DCSBL DCSBL commented Jan 11, 2025

Proposed change

Add sensors for state of charge and cycles to prepare support for HomeWizard Plug-In Battery.

This product can not yes be added to HomeWizard as adding v2-API devices is not yet supported (#135414), and the battery is v2-only. But this is a nice standalone change.

Note: The HWE-BAT fixture itself is 'fake'; it is as-if the battery has v1 support. But this allows us to enable the unit tests. This fixture will be updated during the implementation of v2.

19f35cbc-b865-42df-8cd1-14cfa0da9b47
(Name of state of change sensor has been renamed after this screenshot)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@DCSBL DCSBL force-pushed the add-homewizard-battery-sensors branch from e5b9f7d to 7f60d0b Compare January 13, 2025 12:51
@DCSBL DCSBL marked this pull request as ready for review January 13, 2025 13:23
@frenck frenck marked this pull request as draft January 13, 2025 19:39
@DCSBL DCSBL changed the base branch from dev to intermediate-homewizard-v2-api January 23, 2025 13:11
@DCSBL
Copy link
Contributor Author

DCSBL commented Jan 23, 2025

Supressed by #136353

@DCSBL DCSBL closed this Jan 23, 2025
@DCSBL DCSBL deleted the add-homewizard-battery-sensors branch January 23, 2025 16:29
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant