Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add re-configure flow incomfort integration #135887

Merged
merged 3 commits into from
Jan 19, 2025
Merged

Add re-configure flow incomfort integration #135887

merged 3 commits into from
Jan 19, 2025

Conversation

jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Jan 17, 2025

Proposed change

Add re-configure flow incomfort integration

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

homeassistant/components/incomfort/config_flow.py Outdated Show resolved Hide resolved
"unknown": "Unknown error when connection to Lan2RF gateway."
"timeout_error": "Time out when connecting to Lan2RF gateway.",
"reconfigure_successful": "[%key:common::config_flow::abort::reconfigure_successful%]",
"unknown": "Unknown error when connecting to Lan2RF gateway."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we never abort with unknown right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Same applie to some other errors. We should address this in a different PR. As the changes here are just about formatting/sorting.

tests/components/incomfort/test_config_flow.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft January 19, 2025 11:55
@jbouwh jbouwh force-pushed the incomfort-reconfigure branch from 8ff5eaa to ecbc679 Compare January 19, 2025 13:38
@jbouwh jbouwh marked this pull request as ready for review January 19, 2025 13:41
@home-assistant home-assistant bot requested a review from joostlek January 19, 2025 13:41
@jbouwh jbouwh merged commit 3077a4c into dev Jan 19, 2025
32 checks passed
@jbouwh jbouwh deleted the incomfort-reconfigure branch January 19, 2025 14:16
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants