Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyenphase to 1.23.1 #136200

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Conversation

catsmanac
Copy link
Contributor

@catsmanac catsmanac commented Jan 21, 2025

Proposed change

Bump pyenphase to 1.23.1,

https://github.com/pyenphase/pyenphase/releases/tag/v1.23.1

Changes in this release: pyenphase/pyenphase@v1.23.0...v1.23.1

Select.py updated for possible None from pyenphase for storage_settings.mode.
test_select.py extended with test case.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @bdraco, @cgarwood, @joostlek, mind taking a look at this pull request as it has been labeled with an integration (enphase_envoy) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of enphase_envoy can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign enphase_envoy Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Comment on lines 121 to 123
value_fn=lambda storage_settings: None
if not storage_settings.mode
else STORAGE_MODE_MAP[storage_settings.mode],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the mode in this case? considered using .get()?

Anyway, let's wrap multiline lambdas in parenthesis

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Value_fn will be None and resulting State will be unknown. User can set it to one of the defined states if desired, but in practice the switch will never be created and code not executed. But data in library changed from EnvoyStorageMode to EnvoyStorageMode | None and mypy ci check didn't like it. Hence the added test.

(Issue is with None not being a key in STORAGE_MODE_MAP, .get still returns None)

Parenthesis added for the lambda.

@home-assistant home-assistant bot marked this pull request as draft January 22, 2025 12:25
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@catsmanac catsmanac marked this pull request as ready for review January 22, 2025 18:53
@home-assistant home-assistant bot requested a review from joostlek January 22, 2025 18:53
@joostlek joostlek merged commit c98df36 into home-assistant:dev Jan 23, 2025
46 checks passed
@catsmanac
Copy link
Contributor Author

Thanks for the review Joost, @joostlek

@catsmanac catsmanac deleted the pyenphase_1.23.1 branch January 23, 2025 18:27
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enphase Envoy Error - "None is not a valid EnvoyStorageMode"
4 participants