Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyHomee to 1.2.3 #136213

Merged
merged 49 commits into from
Jan 22, 2025
Merged

Bump pyHomee to 1.2.3 #136213

merged 49 commits into from
Jan 22, 2025

Conversation

Taraman17
Copy link
Contributor

@Taraman17 Taraman17 commented Jan 21, 2025

Breaking change

Proposed change

Update pyHomee library for Homee integration to latest version with following changes:

  • fix: Move py.typed to the correct folder (f2614a4)
  • fix: Minor improvements and cleanup (71cbdab)
  • fix: connection_listeners typing (d2bc9ae)
  • fix: Add unknown value 4 to AttributeChangedBy (925a167)
  • fix: deprecated WebSocketsClientProtocol (ecd298c)
  • fix: typing of HomeeNode._attribute_map (bf315a2)

Diff: Taraman17/pyHomee@v1.2.0...v1.2.3

Activating py.typed made some fixes to the integration necessary.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

zweckj
zweckj previously requested changes Jan 22, 2025
Copy link
Member

@zweckj zweckj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to break mypy

@home-assistant home-assistant bot marked this pull request as draft January 22, 2025 07:30
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Taraman17
Copy link
Contributor Author

Thanks I noticed this also, fix is in preparation.
Do I need to prepare both PRs in parallel then or first the integration fix?

@zweckj
Copy link
Member

zweckj commented Jan 22, 2025

Thanks I noticed this also, fix is in preparation. Do I need to prepare both PRs in parallel then or first the integration fix?

  • is it broken in dev already -> first the fix
  • is this PR breaking the typing -> include in this PR

@Taraman17
Copy link
Contributor Author

Thank you, the latter is the case - update coming

@Taraman17 Taraman17 marked this pull request as ready for review January 22, 2025 12:38
@home-assistant home-assistant bot requested a review from zweckj January 22, 2025 12:38
@joostlek joostlek changed the title Bump pyHomee to 1.2.2 Bump pyHomee to 1.2.3 Jan 22, 2025
homeassistant/components/homee/entity.py Outdated Show resolved Hide resolved
homeassistant/components/homee/entity.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft January 22, 2025 18:45
@Taraman17 Taraman17 marked this pull request as ready for review January 22, 2025 19:01
@home-assistant home-assistant bot requested a review from joostlek January 22, 2025 19:01
@joostlek joostlek merged commit ea1cec2 into home-assistant:dev Jan 22, 2025
45 of 46 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2025
@Taraman17 Taraman17 deleted the homee_sensor branch January 27, 2025 22:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants