Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress color_temp warning if color_temp_kelvin is provided #136884

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Djelibeybi
Copy link
Contributor

@Djelibeybi Djelibeybi commented Jan 30, 2025

Proposed change

As there seem to be a lot of existing components that send both color_temp and color_temp_kelvin, this fix suppresses the warning about using color_temp if color_temp_kelvin is also provided in the same service call.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@Djelibeybi Djelibeybi force-pushed the lifx-suppress-color-temp-warnings branch from 4bd203d to 43daf0a Compare January 30, 2025 03:50
@Djelibeybi Djelibeybi changed the title Supress color_temp warning if color_temp_kelvin is provided Suppress color_temp warning if color_temp_kelvin is provided Jan 30, 2025
@Djelibeybi Djelibeybi force-pushed the lifx-suppress-color-temp-warnings branch from 43daf0a to ebd34fe Compare January 30, 2025 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment