Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a template function to access area attributes #136974

Closed
wants to merge 2 commits into from

Conversation

jpbede
Copy link
Member

@jpbede jpbede commented Jan 31, 2025

Proposed change

Add a new template function area_attr to access the attributes (e.g. temperature_entity_id) of an area.

Tagged this for 2025.2, as there is no other possibility to use the new area attributes temperature_entity_id and humidity_entity_id.

TODO: Docs

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Sorry, something went wrong.

@arturpragacz
Copy link
Contributor

arturpragacz commented Jan 31, 2025

I don't think we should be allowing access to all attributes of the area entry indiscriminately.

I would rather see API more like:

preferred_for_area("kitchen", "temperature")

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@balloob
Copy link
Member

balloob commented Jan 31, 2025

So I think that we should have some more discussion about how we want to expose this in templates, and not rush it into the beta. I like what Artur suggests, maybe combined with an opt-out approach to automatically detect a sensor.

@jpbede jpbede removed this from the 2025.2.0 milestone Jan 31, 2025
@jpbede
Copy link
Member Author

jpbede commented Jan 31, 2025

So I think that we should have some more discussion about how we want to expose this in templates, and not rush it into the beta. I like what Artur suggests, maybe combined with an opt-out approach to automatically detect a sensor.

Sure thing, I'm absolutely fine with that. I'll close this PR for now, I think we should then discuss this in an architectural proposal.

@jpbede jpbede closed this Jan 31, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants