Add support for Shelly Flood gen4 #136981
Conversation
chemelli74
requested review from
balloob,
bieniu,
thecode and
bdraco
as code owners
|
Hey there @balloob, @bieniu, @thecode, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
chemelli74
changed the title
| name="Error", | ||
| device_class=BinarySensorDeviceClass.PROBLEM, | ||
| entity_category=EntityCategory.DIAGNOSTIC, | ||
| extra_state_attributes=lambda value: {"error": value}, |
There was a problem hiding this comment.
I think we should avoid expanding the usage of extra_state_attributes, currently we have only 3 usages of extra_state_attributes, all in Gen1 which added in very early stages of the integration.
If this information is needed we should create another entity with it.
There was a problem hiding this comment.
We can go with either approaches, but for me the error info is so related to the binary sensor status that makes more sense to have then in a single "place".
There was a problem hiding this comment.
If we know that the errors value can contain a list of errors then we should implement a separate entity for each type of error.
There was a problem hiding this comment.
The documentation mentions a cable_unplugged error:
Proposed change
Add support for Shelly Flood gen4 sensors
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: