Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more keyboard menus (devices/helpers/scenes/scripts) #24037

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

karwosts
Copy link
Contributor

@karwosts karwosts commented Feb 3, 2025

Proposed change

Fix keyboard usage for various bulk action menus:

  • Scenes Dashboard (bulk actions - category / label / area)
  • Scripts Dashboard (bulk actions - category / label / area)
  • Devices Page (bulk actions - label / area)
  • Helpers Page (bulk actions - category / label)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Contributor

@MindFreeze MindFreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why these were all async before but it looks like they don't need to be

@MindFreeze MindFreeze merged commit 7d1f8d6 into home-assistant:dev Feb 3, 2025
15 checks passed
@karwosts karwosts deleted the keyboard-menus-more branch February 3, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants