Update ZHA device websocket API types #24087
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
puddly
commented
Feb 21, 2025
| next_hop: string; | ||
| } | ||
|
|
||
| export enum RouteStatus { |
There was a problem hiding this comment.
Should this be an enum? Or just a type that is a union of strings?
There was a problem hiding this comment.
Both are used in the codebase 🤷♂️, in this case an enum doesnt add that much value
MindFreeze
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Expose ZHA
Routeobjects in the websocket API and clean up some existing types. This has been present in the ZHA websocket API for well over a year now, we just forgot to update frontend.CC @MindFreeze
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: