Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save theme by user #24200

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from
Draft

Save theme by user #24200

wants to merge 6 commits into from

Conversation

wendevlin
Copy link
Contributor

@wendevlin wendevlin commented Feb 12, 2025

Proposed change

  • Backwards compatible theme by user setting in Profile
  • Migrated depricated mql.addListener to mql.addEventListener
  • add switch theme animation for supported browsers (not Firefox)

image

image

Screencast.From.2025-02-13.16-01-34.mp4

Known bugs:

  • if storeState is called from any change it will set the browser theme 🙈

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@wendevlin wendevlin changed the title Add save theme for user functionality Save theme by user Feb 12, 2025
@bramkragten bramkragten added the Needs UX Pull requests requiring a review from the Home Assistant design team label Feb 12, 2025
@wendevlin wendevlin marked this pull request as ready for review February 13, 2025 15:03
@wendevlin wendevlin removed the Needs UX Pull requests requiring a review from the Home Assistant design team label Feb 18, 2025
@wendevlin wendevlin marked this pull request as draft February 26, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants