Render todo items with no state, change look of read only items #24529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Demo
emontnemery
reviewed
Mar 7, 2025
| @@ -25,7 +25,7 @@ export enum TodoSortMode { | |||
| export interface TodoItem { | |||
| uid: string; | |||
| summary: string; | |||
| status: TodoItemStatus; | |||
| status?: TodoItemStatus; | |||
There was a problem hiding this comment.
I think this is closer to the typing in core
Suggested change
| status?: TodoItemStatus; | |
| status: TodoItemStatus | null; |
| @@ -319,10 +334,16 @@ export class HuiTodoListCard extends LitElement implements LovelaceCard { | |||
| "ui.panel.lovelace.cards.todo-list.no_unchecked_items" | |||
There was a problem hiding this comment.
It's a bit weird to show this if there are todo-items without status. Maybe only show this if both uncheckedItems and itemsWithoutStatus are empty?
Comment on lines
+337
to
+342
| ${itemsWithoutStatus.length | ||
| ? html` | ||
| <div class="divider" role="seperator"></div> | ||
| ${this._renderItems(itemsWithoutStatus, unavailable)} | ||
| ` | ||
| : nothing} |
There was a problem hiding this comment.
Shouldn't this have a title? Also, if the list supports reordering and there are no active items the menu for reordering is currently not shown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Todo items without state would never be shown.
Read only items would be shown as disabled, now only the checkbox is disabled, and the item is made noninteractive.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: