Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable energy distribution animation if prefers-reduced-motion is set #24581

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

karwosts
Copy link
Contributor

@karwosts karwosts commented Mar 10, 2025

Proposed change

Remove the animated moving dots on energy distribution if prefers-reduced-motion is set.

I believe these are kind of unnecessary to convey the information (and happen to consume high cpu).

I can't decide if this is an accessibility issue, but seems like it might qualify. Might also be good for users who want it on a slower or low-power dashboard.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@karwosts karwosts changed the title Disable energy distribution animation if prefers-reduced-motion is set Disable energy distribution animation if prefers-reduced-motion is set Mar 10, 2025
Copy link
Member

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we default it to false and then enable it if there is no prefer-reduced-motions to avoid a first render with animation?

@bramkragten
Copy link
Member

Should we default it to false and then enable it if there is no prefer-reduced-motions to avoid a first render with animation?

Or we do the match media before rendering

@karwosts
Copy link
Contributor Author

Moved from firstUpdated to willUpdate (conditioned on hasUpdated).

Also added a check to disable the home energy "spin-in" animation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants