-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SwitchBot (Cloud) Bot to list of supported devices #36920
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe changes involve updating the SwitchBot Cloud integration documentation to enhance its categorization and platform support. Modifications include the addition of "Button" to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
source/_integrations/switchbot_cloud.markdown (1)
Documentation needs to be expanded for SwitchBot Bot modes
The documentation should be updated to include:
- Different operational modes for Bot devices (switchMode, customizeMode, pressMode)
- How these modes affect the device's behavior in Home Assistant (switch vs. button entities)
- Configuration guidance for each mode
🔗 Analysis chain
Line range hint
1-72
: Verify documentation completeness against core PRPlease verify that all features and configurations introduced in the core PR (#135606) are properly documented here.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Fetch the core PR to cross-reference features that need documentation gh api repos/home-assistant/core/pulls/135606 --jq '.body' || echo "Unable to fetch PR details"Length of output: 4648
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/switchbot_cloud.markdown
(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (2)
source/_integrations/switchbot_cloud.markdown (2)
5-5
: LGTM! Category addition follows documentation standardsThe "Button" category is appropriately added and correctly placed in alphabetical order.
21-21
: LGTM! Platform addition follows documentation standardsThe "button" platform is appropriately added and correctly placed in alphabetical order.
@@ -54,6 +56,7 @@ Please note, device names configured in the SwitchBot app are transferred into H | |||
- Hub 2 | |||
- Relay Switch 1 | |||
- Relay Switch 1PM | |||
- Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add documentation details for the Bot device
While the Bot device is correctly added to the supported devices list, users would benefit from additional documentation details such as:
- Basic description of the Bot device and its capabilities
- Any specific configuration requirements
- Supported features or limitations
This would align with the documentation style of other devices in the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Approved. Can be merged as soon as the parent PR gets merged.
fb2e847
to
0c81dcf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
♻️ Duplicate comments (1)
source/_integrations/switchbot_cloud.markdown (1)
59-59
: 🛠️ Refactor suggestionEnhance Bot device documentation.
While the Bot device's operation modes are listed, users would benefit from additional documentation details such as:
- Basic description of the Bot device and its capabilities
- Any specific configuration requirements
- Supported features or limitations
This would align with the documentation style of other devices in the list.
Example enhancement:
- Bot (as a Switch in `switchMode` and `customizeMode`, as a Button in `pressMode`) + Bot + - A mechanical button pusher that can physically press buttons + - Supports three operation modes: + - Switch mode (`switchMode`): Acts as an on/off switch + - Custom mode (`customizeMode`): Allows custom press patterns + - Press mode (`pressMode`): Single button press action + - Requires physical mounting near the target button + - Can be controlled via the button platform or switch platform depending on the mode
🧹 Nitpick comments (1)
source/_integrations/switchbot_cloud.markdown (1)
Line range hint
21-26
: Maintain alphabetical order in platform list.The platforms list should maintain alphabetical order for consistency. The "button" platform should be moved after "climate".
ha_platforms: - - button - climate + - button - lock - sensor - switch - vacuum
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/switchbot_cloud.markdown
(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
Proposed change
Add details of the SwitchBot Bot added in this PR.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit