Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SwitchBot (Cloud) Bot to list of supported devices #36920

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

mckbrmn
Copy link

@mckbrmn mckbrmn commented Jan 14, 2025

Proposed change

Add details of the SwitchBot Bot added in this PR.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • New Features
    • Added support for Button category in SwitchBot Cloud integration
    • Introduced support for button platform
    • Added new supported device: Bot with multiple operational modes

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Jan 14, 2025
Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 0c81dcf
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/6787d4b5627e2c0008195c2a
😎 Deploy Preview https://deploy-preview-36920--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Jan 14, 2025

📝 Walkthrough

Walkthrough

The changes involve updating the SwitchBot Cloud integration documentation to enhance its categorization and platform support. Modifications include the addition of "Button" to the ha_category list, the introduction of "button" to the ha_platforms list, and the inclusion of a new supported device "Bot" in the supported devices section, detailing its operational modes.

Changes

File Change Summary
source/_integrations/switchbot_cloud.markdown - Added "Button" to ha_category
- Added "button" to ha_platforms
- Included new supported device "Bot" with modes of operation

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🔭 Outside diff range comments (1)
source/_integrations/switchbot_cloud.markdown (1)

Documentation needs to be expanded for SwitchBot Bot modes

The documentation should be updated to include:

  • Different operational modes for Bot devices (switchMode, customizeMode, pressMode)
  • How these modes affect the device's behavior in Home Assistant (switch vs. button entities)
  • Configuration guidance for each mode
🔗 Analysis chain

Line range hint 1-72: Verify documentation completeness against core PR

Please verify that all features and configurations introduced in the core PR (#135606) are properly documented here.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Fetch the core PR to cross-reference features that need documentation

gh api repos/home-assistant/core/pulls/135606 --jq '.body' || echo "Unable to fetch PR details"

Length of output: 4648

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 38e8c87 and fb2e847.

📒 Files selected for processing (1)
  • source/_integrations/switchbot_cloud.markdown (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (2)
source/_integrations/switchbot_cloud.markdown (2)

5-5: LGTM! Category addition follows documentation standards

The "Button" category is appropriately added and correctly placed in alphabetical order.


21-21: LGTM! Platform addition follows documentation standards

The "button" platform is appropriately added and correctly placed in alphabetical order.

@@ -54,6 +56,7 @@ Please note, device names configured in the SwitchBot app are transferred into H
- Hub 2
- Relay Switch 1
- Relay Switch 1PM
- Bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Add documentation details for the Bot device

While the Bot device is correctly added to the supported devices list, users would benefit from additional documentation details such as:

  1. Basic description of the Bot device and its capabilities
  2. Any specific configuration requirements
  3. Supported features or limitations

This would align with the documentation style of other devices in the list.

frenck
frenck previously approved these changes Jan 14, 2025
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Jan 14, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

♻️ Duplicate comments (1)
source/_integrations/switchbot_cloud.markdown (1)

59-59: 🛠️ Refactor suggestion

Enhance Bot device documentation.

While the Bot device's operation modes are listed, users would benefit from additional documentation details such as:

  1. Basic description of the Bot device and its capabilities
  2. Any specific configuration requirements
  3. Supported features or limitations

This would align with the documentation style of other devices in the list.

Example enhancement:

- Bot (as a Switch in `switchMode` and `customizeMode`, as a Button in `pressMode`)
+ Bot
+   - A mechanical button pusher that can physically press buttons
+   - Supports three operation modes:
+     - Switch mode (`switchMode`): Acts as an on/off switch
+     - Custom mode (`customizeMode`): Allows custom press patterns
+     - Press mode (`pressMode`): Single button press action
+   - Requires physical mounting near the target button
+   - Can be controlled via the button platform or switch platform depending on the mode
🧹 Nitpick comments (1)
source/_integrations/switchbot_cloud.markdown (1)

Line range hint 21-26: Maintain alphabetical order in platform list.

The platforms list should maintain alphabetical order for consistency. The "button" platform should be moved after "climate".

ha_platforms:
-  - button
   - climate
+  - button
   - lock
   - sensor
   - switch
   - vacuum
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fb2e847 and 0c81dcf.

📒 Files selected for processing (1)
  • source/_integrations/switchbot_cloud.markdown (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits-parent Awaits the merge of an parent PR has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants