-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update solax.markdown #36983
base: current
Are you sure you want to change the base?
Update solax.markdown #36983
Conversation
Reverse wifi proxy not needed anymy
📝 WalkthroughWalkthroughThe pull request involves modifications to the Solax integration documentation in the source markdown file. The changes specifically remove a section that provided detailed guidance for users with certain inverter models experiencing API access limitations. The removed content included instructions for setting up a reverse proxy using NGINX and a Raspberry Pi to work around connectivity issues when inverters do not expose their API on home Wi-Fi networks. Changes
Note: Since the changes are purely documentation-related and do not involve code modifications or flow changes, a sequence diagram is not applicable in this scenario. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
As code owner for the solax integration this change looks good! We have not required this reverse proxy for a while. Removing it from the docs will make things less confusing. |
Reverse wifi proxy not needed anymy
Proposed change
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
Note: The removal of this documentation may impact users with certain inverter models who require alternative setup methods.