Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable linux-firmware zstd compression #3898

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

sairon
Copy link
Member

@sairon sairon commented Feb 25, 2025

Disable downstream option for linux-firmware compression. With #3877 it's not needed for x86 anymore and other boards don't need it. Eventually the higher EROFS compression for firmwares and modules can be enabled for other targets as well.

Summary by CodeRabbit

  • Chores
    • Removed firmware compression functionality—including the Zstandard compression method—from multiple platform configurations.
    • Firmware packages continue to be included in builds, ensuring consistent firmware support while streamlining build processes.

Disable downstream option for linux-firmware compression. With #3877 it's not
needed for x86 anymore and other boards don't need it. Eventually the higher
EROFS compression for firmwares and modules can be enabled for other targets as
well.
@sairon sairon added board/raspberrypi Raspberry Pi Boards board/ova Open Virtual Appliance (Virtual Machine) board/odroid Hardkernel's ODROID Boards board/tinker ASUS' Tinker Boards board/khadas Khadas VIM Boards board/yellow Home Assistant Yellow board/generic-aarch64 Generic aarch64 machine board/green Home Assistant Green labels Feb 25, 2025
Copy link

coderabbitai bot commented Feb 25, 2025

📝 Walkthrough

Walkthrough

Multiple Buildroot configuration files have been updated to remove Linux firmware compression options. In each defconfig file, the options for enabling firmware compression and for using Zstandard (ZSTD) compression have been removed while leaving the rest of the firmware configuration unchanged.

Changes

File(s) Change Summary
buildroot-external/configs/*_defconfig (e.g., generic_aarch64, green, khadas_vim3, odroid_, ova, rpi, tinker, yellow) Removed Linux firmware compression options: BR2_PACKAGE_LINUX_FIRMWARE_COMPRESS and BR2_PACKAGE_LINUX_FIRMWARE_COMPRESS_ZSTD.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bdcc2b9 and e1a272c.

📒 Files selected for processing (18)
  • buildroot-external/configs/generic_aarch64_defconfig (0 hunks)
  • buildroot-external/configs/green_defconfig (0 hunks)
  • buildroot-external/configs/khadas_vim3_defconfig (0 hunks)
  • buildroot-external/configs/odroid_c2_defconfig (0 hunks)
  • buildroot-external/configs/odroid_c4_defconfig (0 hunks)
  • buildroot-external/configs/odroid_m1_defconfig (0 hunks)
  • buildroot-external/configs/odroid_m1s_defconfig (0 hunks)
  • buildroot-external/configs/odroid_n2_defconfig (0 hunks)
  • buildroot-external/configs/odroid_xu4_defconfig (0 hunks)
  • buildroot-external/configs/ova_defconfig (0 hunks)
  • buildroot-external/configs/rpi2_defconfig (0 hunks)
  • buildroot-external/configs/rpi3_64_defconfig (0 hunks)
  • buildroot-external/configs/rpi3_defconfig (0 hunks)
  • buildroot-external/configs/rpi4_64_defconfig (0 hunks)
  • buildroot-external/configs/rpi4_defconfig (0 hunks)
  • buildroot-external/configs/rpi5_64_defconfig (0 hunks)
  • buildroot-external/configs/tinker_defconfig (0 hunks)
  • buildroot-external/configs/yellow_defconfig (0 hunks)
💤 Files with no reviewable changes (18)
  • buildroot-external/configs/ova_defconfig
  • buildroot-external/configs/odroid_c4_defconfig
  • buildroot-external/configs/odroid_c2_defconfig
  • buildroot-external/configs/yellow_defconfig
  • buildroot-external/configs/odroid_m1_defconfig
  • buildroot-external/configs/rpi4_defconfig
  • buildroot-external/configs/rpi3_defconfig
  • buildroot-external/configs/tinker_defconfig
  • buildroot-external/configs/green_defconfig
  • buildroot-external/configs/odroid_n2_defconfig
  • buildroot-external/configs/rpi5_64_defconfig
  • buildroot-external/configs/khadas_vim3_defconfig
  • buildroot-external/configs/rpi4_64_defconfig
  • buildroot-external/configs/rpi2_defconfig
  • buildroot-external/configs/rpi3_64_defconfig
  • buildroot-external/configs/odroid_m1s_defconfig
  • buildroot-external/configs/generic_aarch64_defconfig
  • buildroot-external/configs/odroid_xu4_defconfig

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sairon sairon requested a review from agners February 25, 2025 14:05
@sairon sairon merged commit b3ce713 into dev Feb 25, 2025
3 checks passed
@sairon sairon deleted the disable-linux-fw-compression branch February 25, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
board/generic-aarch64 Generic aarch64 machine board/green Home Assistant Green board/khadas Khadas VIM Boards board/odroid Hardkernel's ODROID Boards board/ova Open Virtual Appliance (Virtual Machine) board/raspberrypi Raspberry Pi Boards board/tinker ASUS' Tinker Boards board/yellow Home Assistant Yellow cla-signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants